fix(keyring-controller): await generateRandomMnemonic explicitly

MetaMask · Jan 6, 2025 · 865cff8 · 865cff8
1 parent 89c04a1
commit 865cff8
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/packages/keyring-controller/src/KeyringController.ts b/packages/keyring-controller/src/KeyringController.ts
@@ -2199,7 +2199,10 @@ export class KeyringController extends BaseController<
         );
       }
 
-      keyring.generateRandomMnemonic();
+      // NOTE: Not all keyrings implement this method in a asynchronous-way. Using `await` for
+      // non-thenable will still be valid (despite not being really useful). It allows us to cover both
+      // cases and allow retro-compatibility too.
+      await keyring.generateRandomMnemonic();
       await keyring.addAccounts(1);
     }