fix: apply review feedback

MetaMask · Oct 31, 2024 · d0b8a4e · d0b8a4e
1 parent 9dfe213
commit d0b8a4e
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 16 deletions.
diff --git a/packages/assets-controllers/CHANGELOG.md b/packages/assets-controllers/CHANGELOG.md
@@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 
-- Add `resetState` method to `NftController`, `TokensController`, `TokenBalancesController` and `TokenRatesController` to reset the controller's state back to their initial state ([#4880](https://github.com/MetaMask/core/pull/4880))
+- Add `resetState` method to `NftController`, `TokensController`, `TokenBalancesController` and `TokenRatesController` to reset the controller's state back to their default state ([#4880](https://github.com/MetaMask/core/pull/4880))
 
 ## [41.0.0]
 

diff --git a/packages/assets-controllers/src/NftController.ts b/packages/assets-controllers/src/NftController.ts
@@ -2065,10 +2065,8 @@ export class NftController extends BaseController<
    * Reset the controller state to the initial state.
    */
   resetState() {
-    this.update((state) => {
-      state.allNftContracts = {};
-      state.allNfts = {};
-      state.ignoredNfts = [];
+    this.update(() => {
+      return getDefaultNftControllerState();
     });
   }
 }

diff --git a/packages/assets-controllers/src/TokenBalancesController.ts b/packages/assets-controllers/src/TokenBalancesController.ts
@@ -225,8 +225,8 @@ export class TokenBalancesController extends BaseController<
    * Reset the controller state to the initial state.
    */
   resetState() {
-    this.update((state) => {
-      state.contractBalances = {};
+    this.update(() => {
+      return getDefaultTokenBalancesState();
     });
   }
 }

diff --git a/packages/assets-controllers/src/TokenRatesController.ts b/packages/assets-controllers/src/TokenRatesController.ts
@@ -761,8 +761,8 @@ export class TokenRatesController extends StaticIntervalPollingController<TokenR
    * Reset the controller state to the initial state.
    */
   resetState() {
-    this.update((state) => {
-      state.marketData = {};
+    this.update(() => {
+      return getDefaultTokenRatesControllerState();
     });
   }
 }

diff --git a/packages/assets-controllers/src/TokensController.ts b/packages/assets-controllers/src/TokensController.ts
@@ -1082,13 +1082,8 @@ export class TokensController extends BaseController<
    * Reset the controller state to the initial state.
    */
   resetState() {
-    this.update((state) => {
-      state.tokens = [];
-      state.ignoredTokens = [];
-      state.detectedTokens = [];
-      state.allTokens = {};
-      state.allIgnoredTokens = {};
-      state.allDetectedTokens = {};
+    this.update(() => {
+      return getDefaultTokensState();
     });
   }
 }