chore: swap tokenList with tokensChainsCache in tokenDetectionController #4821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MajorLift
reviewed
Oct 23, 2024
kanthesha
reviewed
Oct 23, 2024
kanthesha
reviewed
Oct 25, 2024
kanthesha
reviewed
Oct 25, 2024
kanthesha
reviewed
Oct 25, 2024
kanthesha
reviewed
Oct 25, 2024
…-tokensChainCache
cryptodev-2s
approved these changes
Oct 29, 2024
sahar-fehri
deleted the
chore/update-tokenDetectionController-to-use-tokensChainCache
branch
7 tasks
sethkfman
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Oct 30, 2024
## **Description** Patches tokenDetection updates to swap tokenList with tokensChainsCache ## **Related issues** Fixes: Related: MetaMask/core#4821 ## **Manual testing steps** 1. I added a console.log in detectTokens fct in tokenDetectionController to check how many times its being called 2. Switch between two networks back and forth and detectTokens should be triggered just once 3. If you switch to a new network for the first time you will see an extra call but it should happen only the first time and not everytime ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/406ac8c3-d7a0-4b37-b4c0-398d0ff60bef ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/2c737fb5-926a-4c6a-8a98-d240022145ef ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
PR to remove usage of tokenList from tokenDetectionController and instead use tokensChainsCache.
References
Changelog
@metamask/assets-controllersTokensChainsCachefrom tokenListControllerChecklist