Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add phishing-controller to package release section of CODEOWNERS file #4876

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Add phishing-controller to package release section of CODEOWNERS file #4876

merged 2 commits into from
Oct 30, 2024

Conversation

MajorLift
Copy link
Contributor

Explanation

References

Changelog

No user-facing changes.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@MajorLift MajorLift self-assigned this Oct 30, 2024
@MajorLift MajorLift requested a review from a team as a code owner October 30, 2024 18:13
@MajorLift MajorLift changed the title Add phishing-controller package to package release section of CODEOWNERS file Add phishing-controller to package release section of CODEOWNERS file Oct 30, 2024
Gudahtt
Gudahtt approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MajorLift MajorLift merged commit 4dc714d into main Oct 30, 2024
119 checks passed
@MajorLift MajorLift deleted the jongsun/chore/241030-codeowners-fix branch October 30, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptodev-2s cryptodev-2s cryptodev-2s approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees

@MajorLift MajorLift

Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MajorLift @Gudahtt @cryptodev-2s