Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TokenDetectionController] pass header to accounts API #4877

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented Oct 31, 2024

Explanation

Following the documentation in https://docs.cx.metamask.io/docs/further-info/internalClientId, pass a x-metamask-clientproduct header when calling the account api.

References

Changelog

@metamask/assets-controllers

  • BREAKING: A platform argument must now be passed to the TokenDetectionController constructor.
  • CHANGED: The TokenDetectionController now passes a x-metamask-clientproduct header when calling the account API.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@bergeron bergeron requested a review from a team as a code owner October 31, 2024 00:36
@bergeron bergeron merged commit d16f2f8 into main Oct 31, 2024
119 checks passed
@bergeron bergeron deleted the brian/account-api-header branch October 31, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants