feat: Add accepted and rejected events to ApprovalController
#5127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
7 tasks
pedronfigueiredo
previously approved these changes
Jan 15, 2025
digiwand
previously approved these changes
Jan 15, 2025
matthewwalsh0
requested changes
Jan 15, 2025
| type: `${typeof controllerName}:rejected`; | ||
| payload: [ | ||
| { | ||
| approval: ApprovalRequest<ApprovalRequestData>; |
There was a problem hiding this comment.
Would request be more explicit here?
| @@ -826,6 +832,15 @@ describe('approval controller', () => { | |||
|
|
|||
| const result = await approvalPromise; | |||
| expect(result).toBe('success'); | |||
|
|
|||
| expect(acceptedEvent.mock.calls[0][0]).toEqual({ | |||
There was a problem hiding this comment.
For maintainability and modularity, should we have distinct tests to verify the events are fired?
OGPoyraz
dismissed stale reviews from digiwand and pedronfigueiredo
via
445749e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR introduces two new
ApprovalControllerevent which is emitted on theApprovalreject or accept actions.ApprovalController:acceptedApprovalController:rejectedReferences
Need to be used in extension: MetaMask/metamask-extension#29656
Changelog
@metamask/approval-controlleracceptedandrejectedevents.Checklist