Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sentry context to erroneous situation callbacks #5139

Merged

Conversation

mathieuartu
Copy link
Contributor

@mathieuartu mathieuartu commented Jan 13, 2025

Explanation

In order to better understand what's happening during erroneous situations, we are adding with this PR an object to all onAccountSyncErroneousSituation calls. This object will be used as a Sentry context on clients.

References

Changelog

@metamask/profile-sync-controller

  • ADDED: Add a context object to onAccountSyncErroneousSituation for better error understanding

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@mathieuartu mathieuartu marked this pull request as ready for review January 13, 2025 19:43
@mathieuartu mathieuartu requested review from a team as code owners January 13, 2025 19:43
@mathieuartu mathieuartu added the team-identity Identity Team changes. https://github.com/orgs/MetaMask/teams/identity label Jan 13, 2025
@mathieuartu mathieuartu self-assigned this Jan 13, 2025
@mathieuartu mathieuartu merged commit 36d5319 into main Jan 14, 2025
117 checks passed
@mathieuartu mathieuartu deleted the feat/add-sentry-context-erroneous-situations-account-syncing branch January 14, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-identity Identity Team changes. https://github.com/orgs/MetaMask/teams/identity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants