feat: persist isAccountSyncingReadyToBeDispatched statue value
#5147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieuartu
added
the
team-identity
|
@metamaskbot publish-preview |
mirceanis
approved these changes
Jan 14, 2025
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
mathieuartu
changed the title
isAccountSyncingReadyToBeDispatched statue value
7 tasks
mathieuartu
deleted the
feat/persist-account-syncing-ready-to-be-dispatched-state
branch
github-merge-queue bot
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Jan 15, 2025
…version (#29701) ## **Description** Account syncing was depending on `_addAccountsWithBalance` to be finished before being triggered. But `_addAccountsWithBalance` was only triggered after onboarding. So people upgrading from a previous version of the extension were not able to use account syncing since `_addAccountsWithBalance` was triggered during their original onboarding, at a time where account syncing was not available. Additionally, the state value `isAccountSyncingReadyToBeDispatched` from `UserStorageController` was not persisted. So people were not able to use account syncing after upgrading their extension version, even coming from a version that had account syncing enabled and working. This PR fixes that, by adding a migration that sets `isAccountSyncingReadyToBeDispatched` to true if `completedOnboarding` is true. Also, bumping `@metamask/profile-sync-controller` to version `v4.1.0` will ensure that `isAccountSyncingReadyToBeDispatched` is persisted. (MetaMask/core#5147) [](https://codespaces.new/MetaMask/metamask-extension/pull/29701?quickstart=1) ## **Related issues** Fixes: #29679 ## **Manual testing steps** 1. Install MetaMask v12.9.3 2. Complete onboarding 3. Upgrade to this PR version 4. Verify that account syncing is working ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/29701?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR changes the
isAccountSyncingReadyToBeDispatchedstate value so it is persisted.References
Changelog
@metamask/profile-sync-controllerisAccountSyncingReadyToBeDispatchedstate value is now persistedChecklist