fix: throw explicit error when KeyringController
is locked
#5172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by:
KeyringController
#5170Explanation
No specific error is thrown when an operation that requires an unlocked vault is attempted while
KeyringController.state.isUnlocked
is false. This doesn't make the operations possible, but it doesn't give a clear error message either.This PR adds an assertion on almost all
KeyringController
methods to check if the controller is unlocked and to throw an error when it isn't.References
Changelog
@metamask/keyring-controller
Checklist