Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Adapt multichain api for sip 26 #5191

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

WIP: Adapt multichain api for sip 26 #5191

wants to merge 12 commits into from

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Jan 23, 2025 •
edited
Loading

Explanation

References

Ticket: https://github.com/orgs/MetaMask/projects/146/views/6?pane=issue&itemId=94617458&issue=MetaMask%7CMetaMask-planning%7C3989
Extension: MetaMask/metamask-extension#29887

Changelog

@metamask/package-a

  • : Your change here
  • : Your change here

@metamask/package-b

  • : Your change here
  • : Your change here

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@jiexi jiexi requested a review from a team as a code owner January 23, 2025 18:12
@jiexi
Copy link
Contributor Author

jiexi commented Jan 23, 2025

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "21.0.2-preview-cba3b99d",
  "@metamask-previews/address-book-controller": "6.0.2-preview-cba3b99d",
  "@metamask-previews/announcement-controller": "7.0.2-preview-cba3b99d",
  "@metamask-previews/approval-controller": "7.1.2-preview-cba3b99d",
  "@metamask-previews/assets-controllers": "46.0.1-preview-cba3b99d",
  "@metamask-previews/base-controller": "7.1.1-preview-cba3b99d",
  "@metamask-previews/build-utils": "3.0.2-preview-cba3b99d",
  "@metamask-previews/composable-controller": "10.0.0-preview-cba3b99d",
  "@metamask-previews/controller-utils": "11.4.5-preview-cba3b99d",
  "@metamask-previews/ens-controller": "15.0.1-preview-cba3b99d",
  "@metamask-previews/eth-json-rpc-provider": "4.1.7-preview-cba3b99d",
  "@metamask-previews/gas-fee-controller": "22.0.2-preview-cba3b99d",
  "@metamask-previews/json-rpc-engine": "10.0.2-preview-cba3b99d",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.6-preview-cba3b99d",
  "@metamask-previews/keyring-controller": "19.0.4-preview-cba3b99d",
  "@metamask-previews/logging-controller": "6.0.3-preview-cba3b99d",
  "@metamask-previews/message-manager": "12.0.0-preview-cba3b99d",
  "@metamask-previews/multichain": "2.1.0-preview-cba3b99d",
  "@metamask-previews/multichain-transactions-controller": "0.0.1-preview-cba3b99d",
  "@metamask-previews/name-controller": "8.0.2-preview-cba3b99d",
  "@metamask-previews/network-controller": "22.1.1-preview-cba3b99d",
  "@metamask-previews/notification-services-controller": "0.16.0-preview-cba3b99d",
  "@metamask-previews/permission-controller": "11.0.5-preview-cba3b99d",
  "@metamask-previews/permission-log-controller": "3.0.2-preview-cba3b99d",
  "@metamask-previews/phishing-controller": "12.3.1-preview-cba3b99d",
  "@metamask-previews/polling-controller": "12.0.2-preview-cba3b99d",
  "@metamask-previews/preferences-controller": "15.0.1-preview-cba3b99d",
  "@metamask-previews/profile-sync-controller": "4.1.1-preview-cba3b99d",
  "@metamask-previews/queued-request-controller": "9.0.0-preview-cba3b99d",
  "@metamask-previews/rate-limit-controller": "6.0.2-preview-cba3b99d",
  "@metamask-previews/remote-feature-flag-controller": "1.3.0-preview-cba3b99d",
  "@metamask-previews/selected-network-controller": "21.0.0-preview-cba3b99d",
  "@metamask-previews/signature-controller": "23.2.0-preview-cba3b99d",
  "@metamask-previews/token-search-discovery-controller": "1.0.0-preview-cba3b99d",
  "@metamask-previews/transaction-controller": "43.0.0-preview-cba3b99d",
  "@metamask-previews/user-operation-controller": "22.0.0-preview-cba3b99d"
}

@jiexi jiexi mentioned this pull request Jan 23, 2025
Draft
7 tasks
@jiexi
Copy link
Contributor Author

jiexi commented Jan 24, 2025

@metamaskbot publish-preview

@jiexi
Copy link
Contributor Author

jiexi commented Jan 24, 2025

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "21.0.2-preview-abb67026",
  "@metamask-previews/address-book-controller": "6.0.2-preview-abb67026",
  "@metamask-previews/announcement-controller": "7.0.2-preview-abb67026",
  "@metamask-previews/approval-controller": "7.1.2-preview-abb67026",
  "@metamask-previews/assets-controllers": "46.0.1-preview-abb67026",
  "@metamask-previews/base-controller": "7.1.1-preview-abb67026",
  "@metamask-previews/build-utils": "3.0.2-preview-abb67026",
  "@metamask-previews/composable-controller": "10.0.0-preview-abb67026",
  "@metamask-previews/controller-utils": "11.4.5-preview-abb67026",
  "@metamask-previews/ens-controller": "15.0.1-preview-abb67026",
  "@metamask-previews/eth-json-rpc-provider": "4.1.7-preview-abb67026",
  "@metamask-previews/gas-fee-controller": "22.0.2-preview-abb67026",
  "@metamask-previews/json-rpc-engine": "10.0.2-preview-abb67026",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.6-preview-abb67026",
  "@metamask-previews/keyring-controller": "19.0.4-preview-abb67026",
  "@metamask-previews/logging-controller": "6.0.3-preview-abb67026",
  "@metamask-previews/message-manager": "12.0.0-preview-abb67026",
  "@metamask-previews/multichain": "2.1.0-preview-abb67026",
  "@metamask-previews/multichain-transactions-controller": "0.0.1-preview-abb67026",
  "@metamask-previews/name-controller": "8.0.2-preview-abb67026",
  "@metamask-previews/network-controller": "22.1.1-preview-abb67026",
  "@metamask-previews/notification-services-controller": "0.16.0-preview-abb67026",
  "@metamask-previews/permission-controller": "11.0.5-preview-abb67026",
  "@metamask-previews/permission-log-controller": "3.0.2-preview-abb67026",
  "@metamask-previews/phishing-controller": "12.3.1-preview-abb67026",
  "@metamask-previews/polling-controller": "12.0.2-preview-abb67026",
  "@metamask-previews/preferences-controller": "15.0.1-preview-abb67026",
  "@metamask-previews/profile-sync-controller": "4.1.1-preview-abb67026",
  "@metamask-previews/queued-request-controller": "9.0.0-preview-abb67026",
  "@metamask-previews/rate-limit-controller": "6.0.2-preview-abb67026",
  "@metamask-previews/remote-feature-flag-controller": "1.3.0-preview-abb67026",
  "@metamask-previews/selected-network-controller": "21.0.0-preview-abb67026",
  "@metamask-previews/signature-controller": "23.2.0-preview-abb67026",
  "@metamask-previews/token-search-discovery-controller": "1.0.0-preview-abb67026",
  "@metamask-previews/transaction-controller": "43.0.0-preview-abb67026",
  "@metamask-previews/user-operation-controller": "22.0.0-preview-abb67026"
}

@jiexi
Copy link
Contributor Author

jiexi commented Jan 29, 2025

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "21.0.2-preview-3fc797ab",
  "@metamask-previews/address-book-controller": "6.0.2-preview-3fc797ab",
  "@metamask-previews/announcement-controller": "7.0.2-preview-3fc797ab",
  "@metamask-previews/approval-controller": "7.1.2-preview-3fc797ab",
  "@metamask-previews/assets-controllers": "46.0.1-preview-3fc797ab",
  "@metamask-previews/base-controller": "7.1.1-preview-3fc797ab",
  "@metamask-previews/build-utils": "3.0.2-preview-3fc797ab",
  "@metamask-previews/composable-controller": "10.0.0-preview-3fc797ab",
  "@metamask-previews/controller-utils": "11.4.5-preview-3fc797ab",
  "@metamask-previews/ens-controller": "15.0.1-preview-3fc797ab",
  "@metamask-previews/eth-json-rpc-provider": "4.1.7-preview-3fc797ab",
  "@metamask-previews/gas-fee-controller": "22.0.2-preview-3fc797ab",
  "@metamask-previews/json-rpc-engine": "10.0.2-preview-3fc797ab",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.6-preview-3fc797ab",
  "@metamask-previews/keyring-controller": "19.0.4-preview-3fc797ab",
  "@metamask-previews/logging-controller": "6.0.3-preview-3fc797ab",
  "@metamask-previews/message-manager": "12.0.0-preview-3fc797ab",
  "@metamask-previews/multichain": "2.1.0-preview-3fc797ab",
  "@metamask-previews/multichain-transactions-controller": "0.0.1-preview-3fc797ab",
  "@metamask-previews/name-controller": "8.0.2-preview-3fc797ab",
  "@metamask-previews/network-controller": "22.1.1-preview-3fc797ab",
  "@metamask-previews/notification-services-controller": "0.17.0-preview-3fc797ab",
  "@metamask-previews/permission-controller": "11.0.5-preview-3fc797ab",
  "@metamask-previews/permission-log-controller": "3.0.2-preview-3fc797ab",
  "@metamask-previews/phishing-controller": "12.3.1-preview-3fc797ab",
  "@metamask-previews/polling-controller": "12.0.2-preview-3fc797ab",
  "@metamask-previews/preferences-controller": "15.0.1-preview-3fc797ab",
  "@metamask-previews/profile-sync-controller": "4.1.1-preview-3fc797ab",
  "@metamask-previews/queued-request-controller": "9.0.0-preview-3fc797ab",
  "@metamask-previews/rate-limit-controller": "6.0.2-preview-3fc797ab",
  "@metamask-previews/remote-feature-flag-controller": "1.3.0-preview-3fc797ab",
  "@metamask-previews/selected-network-controller": "21.0.0-preview-3fc797ab",
  "@metamask-previews/signature-controller": "23.2.0-preview-3fc797ab",
  "@metamask-previews/token-search-discovery-controller": "1.0.0-preview-3fc797ab",
  "@metamask-previews/transaction-controller": "43.0.0-preview-3fc797ab",
  "@metamask-previews/user-operation-controller": "22.0.0-preview-3fc797ab"
}

@jiexi
Copy link
Contributor Author

jiexi commented Jan 29, 2025

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "21.0.2-preview-b6ada138",
  "@metamask-previews/address-book-controller": "6.0.2-preview-b6ada138",
  "@metamask-previews/announcement-controller": "7.0.2-preview-b6ada138",
  "@metamask-previews/approval-controller": "7.1.2-preview-b6ada138",
  "@metamask-previews/assets-controllers": "46.0.1-preview-b6ada138",
  "@metamask-previews/base-controller": "7.1.1-preview-b6ada138",
  "@metamask-previews/build-utils": "3.0.2-preview-b6ada138",
  "@metamask-previews/composable-controller": "10.0.0-preview-b6ada138",
  "@metamask-previews/controller-utils": "11.4.5-preview-b6ada138",
  "@metamask-previews/ens-controller": "15.0.1-preview-b6ada138",
  "@metamask-previews/eth-json-rpc-provider": "4.1.7-preview-b6ada138",
  "@metamask-previews/gas-fee-controller": "22.0.2-preview-b6ada138",
  "@metamask-previews/json-rpc-engine": "10.0.2-preview-b6ada138",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.6-preview-b6ada138",
  "@metamask-previews/keyring-controller": "19.0.4-preview-b6ada138",
  "@metamask-previews/logging-controller": "6.0.3-preview-b6ada138",
  "@metamask-previews/message-manager": "12.0.0-preview-b6ada138",
  "@metamask-previews/multichain": "2.1.0-preview-b6ada138",
  "@metamask-previews/multichain-transactions-controller": "0.0.1-preview-b6ada138",
  "@metamask-previews/name-controller": "8.0.2-preview-b6ada138",
  "@metamask-previews/network-controller": "22.1.1-preview-b6ada138",
  "@metamask-previews/notification-services-controller": "0.17.0-preview-b6ada138",
  "@metamask-previews/permission-controller": "11.0.5-preview-b6ada138",
  "@metamask-previews/permission-log-controller": "3.0.2-preview-b6ada138",
  "@metamask-previews/phishing-controller": "12.3.1-preview-b6ada138",
  "@metamask-previews/polling-controller": "12.0.2-preview-b6ada138",
  "@metamask-previews/preferences-controller": "15.0.1-preview-b6ada138",
  "@metamask-previews/profile-sync-controller": "4.1.1-preview-b6ada138",
  "@metamask-previews/queued-request-controller": "9.0.0-preview-b6ada138",
  "@metamask-previews/rate-limit-controller": "6.0.2-preview-b6ada138",
  "@metamask-previews/remote-feature-flag-controller": "1.3.0-preview-b6ada138",
  "@metamask-previews/selected-network-controller": "21.0.0-preview-b6ada138",
  "@metamask-previews/signature-controller": "23.2.0-preview-b6ada138",
  "@metamask-previews/token-search-discovery-controller": "1.0.0-preview-b6ada138",
  "@metamask-previews/transaction-controller": "43.0.0-preview-b6ada138",
  "@metamask-previews/user-operation-controller": "22.0.0-preview-b6ada138"
}

@jiexi
Copy link
Contributor Author

jiexi commented Jan 29, 2025

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "21.0.2-preview-5dfebad9",
  "@metamask-previews/address-book-controller": "6.0.2-preview-5dfebad9",
  "@metamask-previews/announcement-controller": "7.0.2-preview-5dfebad9",
  "@metamask-previews/approval-controller": "7.1.2-preview-5dfebad9",
  "@metamask-previews/assets-controllers": "46.0.1-preview-5dfebad9",
  "@metamask-previews/base-controller": "7.1.1-preview-5dfebad9",
  "@metamask-previews/build-utils": "3.0.2-preview-5dfebad9",
  "@metamask-previews/composable-controller": "10.0.0-preview-5dfebad9",
  "@metamask-previews/controller-utils": "11.4.5-preview-5dfebad9",
  "@metamask-previews/ens-controller": "15.0.1-preview-5dfebad9",
  "@metamask-previews/eth-json-rpc-provider": "4.1.7-preview-5dfebad9",
  "@metamask-previews/gas-fee-controller": "22.0.2-preview-5dfebad9",
  "@metamask-previews/json-rpc-engine": "10.0.2-preview-5dfebad9",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.6-preview-5dfebad9",
  "@metamask-previews/keyring-controller": "19.0.4-preview-5dfebad9",
  "@metamask-previews/logging-controller": "6.0.3-preview-5dfebad9",
  "@metamask-previews/message-manager": "12.0.0-preview-5dfebad9",
  "@metamask-previews/multichain": "2.1.0-preview-5dfebad9",
  "@metamask-previews/multichain-transactions-controller": "0.0.1-preview-5dfebad9",
  "@metamask-previews/name-controller": "8.0.2-preview-5dfebad9",
  "@metamask-previews/network-controller": "22.1.1-preview-5dfebad9",
  "@metamask-previews/notification-services-controller": "0.17.0-preview-5dfebad9",
  "@metamask-previews/permission-controller": "11.0.5-preview-5dfebad9",
  "@metamask-previews/permission-log-controller": "3.0.2-preview-5dfebad9",
  "@metamask-previews/phishing-controller": "12.3.1-preview-5dfebad9",
  "@metamask-previews/polling-controller": "12.0.2-preview-5dfebad9",
  "@metamask-previews/preferences-controller": "15.0.1-preview-5dfebad9",
  "@metamask-previews/profile-sync-controller": "4.1.1-preview-5dfebad9",
  "@metamask-previews/queued-request-controller": "9.0.0-preview-5dfebad9",
  "@metamask-previews/rate-limit-controller": "6.0.2-preview-5dfebad9",
  "@metamask-previews/remote-feature-flag-controller": "1.3.0-preview-5dfebad9",
  "@metamask-previews/selected-network-controller": "21.0.0-preview-5dfebad9",
  "@metamask-previews/signature-controller": "23.2.0-preview-5dfebad9",
  "@metamask-previews/token-search-discovery-controller": "1.0.0-preview-5dfebad9",
  "@metamask-previews/transaction-controller": "43.0.0-preview-5dfebad9",
  "@metamask-previews/user-operation-controller": "22.0.0-preview-5dfebad9"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jiexi