Update createServicePolicy to expose sub-policies; add re-exports from cockatiel
#5192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
force-pushed
the
add-conveniences-to-create-service-policy
branch
from
95400dc to
53b5f94
Compare
Expose these exports from `cockatiel` so consumers can use them without needing to depend on the library directly: - `BrokenCircuitError` - `CircuitState` - `handleAll` - `handleWhen` Also, update `createServicePolicy` to expose the retry and circuit breaker policies so that we can access their state in other modules that use this utility function. This is needed to be able to create an RPC service.
mcmire
force-pushed
the
add-conveniences-to-create-service-policy
branch
from
53b5f94 to
f63c3d3
Compare
mcmire
changed the title
createServicePolicycreateServicePolicy to expose sub-policies; add re-exports from cockatiel
cryptodev-2s
approved these changes
Jan 24, 2025
zone-live
pushed a commit
that referenced
this pull request
Jan 27, 2025
…rom `cockatiel` (#5192) Expose these exports from `cockatiel` so consumers can use them without needing to depend on the library directly: - `BrokenCircuitError` - `CircuitState` - `handleAll` - `handleWhen` Also, update `createServicePolicy` to expose the retry and circuit breaker policies so that we can access their state in other modules that use this utility function. This is needed to be able to create an RPC service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Expose these exports from
cockatielso consumers can use them without needing to depend on the library directly:BrokenCircuitErrorCircuitStatehandleAllhandleWhenAlso, update
createServicePolicyto expose the retry and circuit breaker policies so that we can access their state in other modules that use this utility function.This is needed to be able to create an RPC service.
References
Progresses #4994.
Pre-requisite to #4990.
Changelog
(Updated in changelog.)
Checklist