fix(deps): update from eth-rpc-errors to @metamask/rpc-errors
#22871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
legobeat
force-pushed
the
deps-eth-rpc-errors
branch
from
31e4a2a to
b075fa9
Compare
legobeat
added
dependencies
|
🎉 |
FrederikBolding
previously approved these changes
Feb 8, 2024
Addressed in c81c503 by updating tests to expect underlying error message in |
FrederikBolding
previously approved these changes
Feb 8, 2024
14 tasks
legobeat
force-pushed
the
deps-eth-rpc-errors
branch
7 times, most recently
from
5d38fdd to
4284831
Compare
legobeat
force-pushed
the
deps-eth-rpc-errors
branch
2 times, most recently
from
79e9598 to
7f3572e
Compare
legobeat
changed the title
eth-rpc-errors to @metamask/rpc-errorseth-rpc-errors to @metamask/rpc-errors
legobeat
force-pushed
the
deps-eth-rpc-errors
branch
3 times, most recently
from
b82f0e9 to
d09d8f7
Compare
legobeat
force-pushed
the
deps-eth-rpc-errors
branch
from
d09d8f7 to
892b0cc
Compare
legobeat
force-pushed
the
deps-eth-rpc-errors
branch
5 times, most recently
from
62c8115 to
95eca84
Compare
This reverts commit e5ae79b.
legobeat
force-pushed
the
deps-eth-rpc-errors
branch
from
95eca84 to
61a4717
Compare
|
This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions. |
|
This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions. |
Gudahtt
pushed a commit
that referenced
this pull request
Oct 16, 2024
…edition) (#24496) ## **Description** - Upgrade from obsolete `eth-rpc-errors` to `@metamask/rpc-errors` - This introduce handling of error causes See [here](MetaMask/rpc-errors#140) for some context. [](https://codespaces.new/MetaMask/metamask-extension/pull/24496?quickstart=1) ## **Related issues** - #22871 #### Blocked by - [x] MetaMask/rpc-errors#158 - [x] MetaMask/rpc-errors#144 - [x] MetaMask/rpc-errors#140 #### Blocking - #22875 ## **Manual testing steps** ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Gudahtt
pushed a commit
that referenced
this pull request
Oct 21, 2024
](https://codespaces.new/MetaMask/metamask-extension/pull/24496?quickstart=1){kind=link}
…edition) (#24496) - Upgrade from obsolete `eth-rpc-errors` to `@metamask/rpc-errors` - This introduce handling of error causes See [here](MetaMask/rpc-errors#140) for some context. [](https://codespaces.new/MetaMask/metamask-extension/pull/24496?quickstart=1) - #22871 - [x] MetaMask/rpc-errors#158 - [x] MetaMask/rpc-errors#144 - [x] MetaMask/rpc-errors#140 - #22875 - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The package
eth-rpc-errorshas been renamed to@metamask/rpc-errorsstarting with version 5. Many controllers and libraries used in extension already use the releases. This updates the direct dependency from[email protected]to@metamask/[email protected].Related issues
@metamask/signature-controllerand related packages #22861@metamask/address-book-controller#22863Blocking
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist