Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temp: test token detection with Accounts API #27863

Conversation

Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Oct 15, 2024

Description

Bumps Assets Controller and tests using the new logic in the TokenDetectionController which uses the Accounts API over multicall RPC.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

use the updated token detection controller which uses the accounts API
@Prithpal-Sooriya Prithpal-Sooriya added the DO-NOT-MERGE Pull requests that should not be merged label Oct 15, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Prithpal-Sooriya
Copy link
Contributor Author

OK this is not easy to test as there is a breaking change added across multiple packages, so a preview branch does not succeed.
MetaMask/core#4752

We can only realistically test this once the updated controller changes are all live. Or we need to modify the change above to be backwards compatible with other older controllers.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DO-NOT-MERGE Pull requests that should not be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant