fix: fix permissions not correctly being updated when all network clients are removed for a chainId

[jiexi]

Description

Fixes a bug where permissions are not being updated when all network clients for a chainId are removed. This results in permittedChains permissions referencing chainIds that are no longer supported and makes it so that the existing permittedChains permissions cannot be modified in any way until either the permission is revoked entirely or the missing network is readded.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3735

Requires: MetaMask/core#5183

Manual testing steps

1. Add a new RPC endpoint for a chainId you do not have network clients for already
2. Add another different RPC endpoint for that same chainId above
3. Permit a dapp to access that chainId
4. Check that you can modify the permitted chains vs the wallet UI
5. Make sure that calling wallet_getPermissions shows the chainId in the endowment:permitted-chains permission
6. Remove one RPC endpoint for that chainId
7. Check that you can modify the permitted chains vs the wallet UI
8. Make sure that calling wallet_getPermissions shows the chainId in the endowment:permitted-chains permission
9. Remove the chainId entirely
10. Check that you can modify the permitted chains vs the wallet UI
11. Make sure that calling wallet_getPermissions shows that the chainId is no longer in the endowment:permitted-chains permission

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [a535556]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1595 ± 71 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1374	1939	1594	146	70
		domContentLoaded	1368	1916	1566	144	69
		load	1373	1931	1595	147	71
		domInteractive	21	78	32	14	7
		backgroundConnect	7	95	31	22	10
		firstReactRender	16	175	47	37	18
		getState	4	58	12	14	7
		initialActions	0	1	0	0	0
		loadScripts	950	1411	1142	117	56
		setupStore	5	62	9	12	6
		uiStartup	1601	2378	1850	223	107

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 120 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[adonesky1]

LGTM!

[metamaskbot]

Builds ready [0928320]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1706 ± 95 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1446	2132	1712	205	99
		domContentLoaded	1431	2069	1681	193	93
		load	1445	2092	1706	198	95
		domInteractive	24	92	42	21	10
		backgroundConnect	7	63	28	17	8
		firstReactRender	16	77	38	22	11
		getState	4	53	14	14	7
		initialActions	0	1	0	0	0
		loadScripts	1047	1585	1237	165	79
		setupStore	6	47	11	9	4
		uiStartup	1619	2424	1911	229	110

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 120 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[Gudahtt]

LGTM! Won't we also need a migration to fully resolve this bug though? Certainly we can do it in a separate PR, but I would expect there to be chainIds from removed networks already in permission state.