Skip to content

Commit

Permalink
chore: cherry-pick 13262 (#13264)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR cherry-picks
#13262 into `7.39.0`

## **Related issues**

Fixes: #13262

## **Manual testing steps**

N/A

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
OGPoyraz authored Jan 30, 2025
1 parent f0dbe03 commit c02032f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion app/util/transactions/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ export async function getTransactionActionKey(transaction, chainId) {
const toSmartContract =
transaction.toSmartContract !== undefined
? transaction.toSmartContract
: await isSmartContractAddress(to, undefined, networkClientId);
: await isSmartContractAddress(to, chainId, networkClientId);

if (toSmartContract) {
return SMART_CONTRACT_INTERACTION_ACTION_KEY;
Expand Down
5 changes: 5 additions & 0 deletions app/util/transactions/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,11 @@ ENGINE_MOCK.context = {
provider: {} as Provider,
}),
},
TokenListController: {
state: {
tokenList: {},
},
},
};

const spyOnQueryMethod = (returnValue: string | undefined) =>
Expand Down

0 comments on commit c02032f

Please sign in to comment.