Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add new translations #12624

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Dec 10, 2024

Description

PR that adds new translation for Portfolio View feature when the asset network is different than the selected network

Related issues

Fixes:

Manual testing steps

  1. Click on "All Networks"
  2. Click on a token that is on a network different than the network you are currently on
  3. Scroll down and you should see "Please switch network to view transactions"

Screenshots/Recordings

Before

After

Screen.Recording.2024-12-12.at.11.49.46.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added portfolio-view Used for PRs and issues related to Q4 2024 portfolio view Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 10, 2024
Copy link
Contributor

github-actions bot commented Dec 10, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c2d8c6a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c6bcfd30-d9e7-405f-9303-ee12d5726d1b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri marked this pull request as ready for review December 10, 2024 14:30
@sahar-fehri sahar-fehri requested a review from a team as a code owner December 10, 2024 14:30
@tommasini
Copy link
Contributor

It seems we have conflicts! Can we also have screenshot of the component and scenario where the translation is used?

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 12, 2024
Copy link
Contributor

github-actions bot commented Dec 12, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7602183
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2917c855-1dd2-41d0-af5f-33e346aac699

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 12, 2024
@sahar-fehri sahar-fehri added this pull request to the merge queue Dec 12, 2024
@sahar-fehri sahar-fehri removed this pull request from the merge queue due to a manual request Dec 12, 2024
@sahar-fehri sahar-fehri added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 5972b5b Dec 12, 2024
46 checks passed
@sahar-fehri sahar-fehri deleted the fix/add-new-translations-for-multichain branch December 12, 2024 13:31
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
@metamaskbot metamaskbot added the release-7.38.0 Issue or pull request that will be included in release 7.38.0 label Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
portfolio-view Used for PRs and issues related to Q4 2024 portfolio view release-7.38.0 Issue or pull request that will be included in release 7.38.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants