You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remote Feature Flag Controller v1.3.0 requires metaMetricsId string value for its initialization. metaMetricsId is used to generate a threshold value for Scope based feature flags.
On Mobile, metaMetricsId is managed by the MetaMetrics class, using its method getMetaMetricsId.
Because this method returns a promise, we need to handle it outside Engine constructor.
The route we opted is to await for the Promise to resolve on EngineService.start function, then send it to Engine.init as a parameter, which will pass it the into Engine constructor.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
@NicolasMassart The motivation to pass the metametrics id Promise rather than the actual value is to avoid adding another argument into the Engine constructor and to avoid turning functions that call Engine.init into async ones.
We can't await for a Promise inside a class constructor.
joaoloureirop
changed the title
feat: Enable feature Flag Values with Scope Based on "threshold" in mobile
feat: Enable feature Flag Values with Scope Based on "threshold"
Jan 16, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
joaoloureirop
force-pushed
the
feat/feature-flag-threshold
branch
from
github-actions
bot
removed
the
needs-dev-review
metamaskbot
added
the
release-7.40.0
Description
Remote Feature Flag Controller v1.3.0 requires
metaMetricsIdstring value for its initialization.metaMetricsIdis used to generate a threshold value for Scope based feature flags.On Mobile,
metaMetricsIdis managed by the MetaMetrics class, using its methodgetMetaMetricsId.Because this method returns a promise, we need to handle it outside Engine constructor.
The route we opted is to await for the Promise to resolve on
EngineService.startfunction, then send it toEngine.initas a parameter, which will pass it the into Engine constructor.Related issues
Fixes: https://github.com/MetaMask/mobile-planning/issues/2065
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist