Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix network selector #12641

Merged
merged 3 commits into from
Dec 12, 2024
Merged

fix: fix network selector #12641

merged 3 commits into from
Dec 12, 2024
+9 −13

Conversation

sahar-fehri
Copy link
Contributor

Description

When a user adds a new network using a dapp; it should display the correct network filter with the correct tokens display

Related issues

Fixes: #12638

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Dec 11, 2024
@sahar-fehri sahar-fehri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 667a0e7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0cc1b641-6e6e-4c76-bded-7260996669c0

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e5673b9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2821eba0-057c-41ba-b851-19c0363a3e79

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri marked this pull request as ready for review December 11, 2024 19:34
@sahar-fehri sahar-fehri requested review from a team as code owners December 11, 2024 19:34
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3ffa829
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1b70d93d-7d4e-4546-8ade-19a9327225fc

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

vinnyhoward
vinnyhoward previously approved these changes Dec 11, 2024
View reviewed changes
@sahar-fehri sahar-fehri requested a review from a team as a code owner December 11, 2024 21:07
@sahar-fehri sahar-fehri force-pushed the fix/fix-network-filter-name-after-adding-network-from-dapp branch from cd892d2 to 3ffa829 Compare December 11, 2024 21:09
@sahar-fehri sahar-fehri removed the request for review from a team December 11, 2024 21:09
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

tommasini
tommasini approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add screenshot of the fix to the PR description

@sahar-fehri sahar-fehri added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 2f0cc61 Dec 12, 2024
71 checks passed
@sahar-fehri sahar-fehri deleted the fix/fix-network-filter-name-after-adding-network-from-dapp branch December 12, 2024 10:30
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
@metamaskbot metamaskbot added the release-7.38.0 Issue or pull request that will be included in release 7.38.0 label Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

@gambinish gambinish gambinish approved these changes

@vinnyhoward vinnyhoward vinnyhoward approved these changes

@bergeron bergeron bergeron approved these changes

Assignees
No one assigned
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-7.38.0 Issue or pull request that will be included in release 7.38.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Portfolio view: after adding custom network from dapps, the tokens list is updated incorrectly
6 participants
@sahar-fehri @bergeron @vinnyhoward @gambinish @tommasini @metamaskbot