-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove global network usage from transaction simulation #12743
refactor: remove global network usage from transaction simulation #12743
Conversation
Bitrise❌❌❌ Commit hash: b436dbb Note
Tip
|
Quality Gate passedIssues Measures |
Bitrise APK build https://app.bitrise.io/build/58ded98d-c154-43f1-8ae4-333844cd8c56?tab=artifacts Simulations across all Popular networks, with the exception of zkSync, function as anticipated. Transactions initiated from dApps: Untitled.movTransactions initiated from whithin the wallet and malicious transactions: 1.movWhen conducting simulations on zkSync, the zksync.mp4rc.mp4I also encountered error which I think is not relate3d to the current PR as I've seen it in the latest RC, also here is Sentry issue with the same error #12521 |
I also can't confirm simulation for NFT due to this issue: #12317 |
Description
Remove any usage of the global network from transaction simulation.
This requires using the
chainId
from theTransactionMeta
, and so theSimulationDetails
properties have been simplified to acceptTransactionMeta
directly to minimise the number of tightly coupled properties.Related issues
Fixes: #2011
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist