Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove global network usage from transaction simulation #12743

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

matthewwalsh0
Copy link
Member

Description

Remove any usage of the global network from transaction simulation.

This requires using the chainId from the TransactionMeta, and so the SimulationDetails properties have been simplified to accept TransactionMeta directly to minimise the number of tightly coupled properties.

Related issues

Fixes: #2011

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 requested review from a team as code owners December 17, 2024 21:48
@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Dec 17, 2024
@matthewwalsh0 matthewwalsh0 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 17, 2024
Copy link
Contributor

github-actions bot commented Dec 17, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b436dbb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/221266af-e4b6-42ff-93b2-62f67ebce3e5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sleepytanya
Copy link
Contributor

Bitrise APK build https://app.bitrise.io/build/58ded98d-c154-43f1-8ae4-333844cd8c56?tab=artifacts

Simulations across all Popular networks, with the exception of zkSync, function as anticipated.

Transactions initiated from dApps:

Untitled.mov

Transactions initiated from whithin the wallet and malicious transactions:

1.mov

When conducting simulations on zkSync, the Estimated changes field appear momentarily and then is no longer visible - the same behavior in the latest RC v7.38.0 (1521) (I'm not sure if this is expected?):

zksync.mp4
rc.mp4

I also encountered error which I think is not relate3d to the current PR as I've seen it in the latest RC, also here is Sentry issue with the same error #12521

Screenshot_20241219_011810_MetaMask

@sleepytanya
Copy link
Contributor

I also can't confirm simulation for NFT due to this issue: #12317

@sleepytanya sleepytanya added the QA Passed A successful QA run through has been done label Dec 19, 2024
@matthewwalsh0 matthewwalsh0 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 20, 2024
@matthewwalsh0 matthewwalsh0 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 20, 2024
@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit c87ac20 Dec 20, 2024
46 of 48 checks passed
@matthewwalsh0 matthewwalsh0 deleted the refactor/remove-global-network-simulations branch December 20, 2024 12:25
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants