Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add ramps URL scheme deeplinking e2e #12747

Merged
merged 20 commits into from
Dec 20, 2024

Conversation

cortisiko
Copy link
Member

@cortisiko cortisiko commented Dec 18, 2024

Description

The purpose of this PR is to add e2e coverage for the URL schema deeplinks in the ramps flow.

The goal here is to ensure that we properly test the URL scheme deep linking in these flows.

Sell Deep link

Scenario 1
Given I open a sell ETH deeplink for mainnet 
Then the app should launch with the ramps build quotes page
And the token I want to sell is displayed correctly
And the amount i want to send is displayed correctly

Scenario 2
Given I open a sell deeplink on an unsupported network
Then the app should launch with the ramps build quotes page
And I am prompted to add the network
When I add the network
Then the Quotes page should be displayed 

Buy deeplink Flow

Scenario 3
Given i deeplink to the buy eth flow on mainnet
Then the app should launch with the ramps build quotes page
And the token I want to sell is displayed correctly
And the amount i want to send is displayed correctly

Scenario 4
Given i deeplink to the buy eth flow on a popular network
Then the app should launch with the ramps build quotes page
And the token I want to sell is displayed correctly
And the amount i want to send is displayed correctly

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

e2e/fixtures/fixture-builder.js Outdated Show resolved Hide resolved
e2e/fixtures/fixture-builder.js Show resolved Hide resolved
e2e/fixtures/fixture-builder.js Show resolved Hide resolved
e2e/fixtures/fixture-builder.js Show resolved Hide resolved
e2e/pages/Ramps/BuildQuoteView.js Show resolved Hide resolved
e2e/pages/Ramps/TokenSelectBottomSheet.js Show resolved Hide resolved
@cortisiko cortisiko marked this pull request as ready for review December 18, 2024 03:52
@cortisiko cortisiko requested a review from a team as a code owner December 18, 2024 03:52
@cortisiko cortisiko added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 18, 2024
Copy link
Contributor

github-actions bot commented Dec 18, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a587792
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0babf372-68a1-4e11-8ecd-c4c0799393bf

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko requested a review from a team as a code owner December 18, 2024 18:43
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.86%. Comparing base (9d6908b) to head (13b237c).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12747      +/-   ##
==========================================
+ Coverage   58.85%   58.86%   +0.01%     
==========================================
  Files        1851     1851              
  Lines       41739    41744       +5     
  Branches     5397     5399       +2     
==========================================
+ Hits        24566    24574       +8     
+ Misses      15502    15501       -1     
+ Partials     1671     1669       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cortisiko cortisiko changed the title test: Add ramps universal deeplinking e2e test: Add ramps universal scheme deeplinking e2e Dec 18, 2024
@cortisiko cortisiko changed the title test: Add ramps universal scheme deeplinking e2e test: Add ramps URL scheme deeplinking e2e Dec 18, 2024
@cortisiko cortisiko removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 19, 2024
@cortisiko cortisiko added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3cea94f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a261ec71-4a73-49c8-a8b0-c673e622f251

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 27b6699
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/17de6e4f-9ab5-45dd-ba5a-facbf59069aa

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko requested a review from wachunei December 20, 2024 02:46
@cortisiko cortisiko added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit bea70f1 Dec 20, 2024
41 checks passed
@cortisiko cortisiko deleted the detox/ramps-universal-deeplinking-e2e branch December 20, 2024 15:29
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants