Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove duplicate @metamask/swaps-controller in package.json #12795

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Dec 19, 2024

Description

This pr removes duplicate @metamask/swaps-controller in package.json

Related issues

Fixes:

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cryptodev-2s cryptodev-2s added No QA Needed Apply this label when your PR does not need any QA effort. team-wallet-framework labels Dec 19, 2024
@cryptodev-2s cryptodev-2s self-assigned this Dec 19, 2024
@cryptodev-2s cryptodev-2s requested a review from a team as a code owner December 19, 2024 14:26
@cryptodev-2s cryptodev-2s changed the title chore: eliminate duplicate dependency entries in package.json chore: remove duplicate dependency entries in package.json Dec 19, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cryptodev-2s cryptodev-2s force-pushed the cryptodev2s/fix-package-json-duplicate-entries branch from 829ac9e to 9f14165 Compare December 19, 2024 14:27
@cryptodev-2s cryptodev-2s requested a review from a team as a code owner December 19, 2024 14:27
@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9f14165
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b3ce3dad-05cf-400d-8e6e-ef50903fa6d5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cryptodev-2s cryptodev-2s added No E2E Smoke Needed If the PR does not need E2E smoke test run and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 19, 2024
@cryptodev-2s cryptodev-2s changed the title chore: remove duplicate dependency entries in package.json chore: remove duplicate @metamask/swaps-controller package.json Dec 19, 2024
@cryptodev-2s cryptodev-2s changed the title chore: remove duplicate @metamask/swaps-controller package.json chore: remove duplicate @metamask/swaps-controller in package.json Dec 19, 2024
@cryptodev-2s cryptodev-2s added the No QA Needed Apply this label when your PR does not need any QA effort. label Dec 19, 2024
@cryptodev-2s cryptodev-2s added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 1670ada Dec 19, 2024
47 of 50 checks passed
@cryptodev-2s cryptodev-2s deleted the cryptodev2s/fix-package-json-duplicate-entries branch December 19, 2024 16:17
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.39.0 Issue or pull request that will be included in release 7.39.0 team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants