Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: @lavamoat/git-safe-dependencies #12814

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Conversation

leotm
Copy link
Member

@leotm leotm commented Dec 20, 2024

Description

Quality Quest 2024 ft. @naugtur and @tommasini b2b

TODO

  • add package
  • integrate in CI
  • update depcheck
  • socket

Related issues

Manual testing steps

  1. Locally update package.json to "react-native-tcp": "aprock/react-native-tcp#11/head"
  2. Run yarn git-safe-dependencies
  3. There should be an error message
  4. Revert package.json to the correct "react-native-tcp": "aprock/react-native-tcp#98fbc801f0586297f16730b2f4c75eef15dfabcd",
  5. Run yarn git-safe-dependencies
  6. great
  7. success

Screenshots/Recordings

Before

e.g. package.json > "react-native-tcp": "aprock/react-native-tcp#11/head",

image

After

fixed to: package.json > "react-native-tcp": "aprock/react-native-tcp#98fbc801f0586297f16730b2f4c75eef15dfabcd",
in #12595

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@leotm leotm changed the title Lavamoat git safe dependencies feat: @lavamoat/git-safe-dependencies Dec 20, 2024
Copy link

socket-security bot commented Dec 20, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@lavamoat/[email protected] network 0 15.9 kB lmbot
npm/@yarnpkg/[email protected] None 0 197 kB yarnbot
npm/[email protected] filesystem 0 42.7 kB lirantal_bot
npm/[email protected] None 0 58.9 kB addaleax

View full report↗︎

Copy link

socket-security bot commented Dec 20, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@lavamoat/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@leotm leotm requested review from naugtur and tommasini December 20, 2024 16:32
@leotm leotm added No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed If the PR does not need E2E smoke test run labels Dec 20, 2024
@leotm
Copy link
Member Author

leotm commented Dec 20, 2024

@SocketSecurity ignore npm/@lavamoat/[email protected]

@leotm leotm marked this pull request as ready for review December 20, 2024 16:39
@leotm leotm requested review from a team as code owners December 20, 2024 16:39
@leotm leotm enabled auto-merge December 20, 2024 16:57
Copy link

@naugtur naugtur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right

Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOVE IT <3

@leotm leotm added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 442d331 Dec 20, 2024
41 checks passed
@leotm leotm deleted the lavamoat-git-safe-dependencies branch December 20, 2024 17:22
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.39.0 Issue or pull request that will be included in release 7.39.0 team-lavamoat team-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants