Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove goerli infura from network state #12838

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Jan 6, 2025

Description

core PR: MetaMask/core#5094

Related issues

Fixes: #12837

Manual testing steps

  1. Run the app locally
  2. you should not see the verbose logs , or any request sent to Goerli

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 709d653
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/85ad3de4-6edd-435e-abc3-ce545dc39690

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

app/store/migrations/065.test.ts Outdated Show resolved Hide resolved
app/store/migrations/065.test.ts Outdated Show resolved Hide resolved
app/store/migrations/065.test.ts Outdated Show resolved Hide resolved
@salimtb salimtb marked this pull request as ready for review January 8, 2025 10:53
@salimtb salimtb requested review from a team as code owners January 8, 2025 10:53
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 51a142d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9c05f462-f0b3-48b3-9ab6-4d7fc8eab6a0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb requested a review from NicolasMassart January 8, 2025 13:14
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@salimtb salimtb added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 2215339 Jan 9, 2025
41 checks passed
@salimtb salimtb deleted the fix/remove-infura-goerli-from-network-state branch January 9, 2025 17:03
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.40.0 Issue or pull request that will be included in release 7.40.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: infura Goerli and linea goerli should be removed from the network controller state
3 participants