Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: MMPD-1528 - View recents and favorites in browser URL modal #12938

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

feat: MMPD-1528 - View recents and favorites in browser URL modal #12938

wants to merge 36 commits into from

Conversation

ziad-saab
Copy link
Contributor

@ziad-saab ziad-saab commented Jan 10, 2025 •
edited
Loading

Description

https://consensyssoftware.atlassian.net/browse/MMPD-1528

Change the behaviour of the browser url autocomplete:

  • add scrolling
  • when nothing is typed, show recents (max 5) and favorites
  • when user starts typing, auto complete from dapp list + recents + favorites
  • adjust styling to match new figma styles

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMPD-1528

Manual testing steps

  1. Go to the in-app browser
  2. Press the URL bar
  3. Observe that the currently typed URL is available as a result, just like in the current version
  4. Clear the input and observe that you see your (up to) 5 latest recents, + favorites, and that you can scroll
  5. Start typing, and observe that you get up to 3 lists: Sites, Recents, and Favorites. The elements shown are matched from what you're typing

Screenshots/Recordings

Before

After

image image image image
Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2025-01-16.at.13.27.04.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@ziad-saab
feat: change browser url modal behavior
81aad30 
- when nothing is typed, show recents (max 5) and favorites
- when user starts typing, show results from the dapp list
@ziad-saab
Merge branch 'main' into zs/new-browser-autocomplete
34651ad
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ziad-saab ziad-saab added needs-qa Any New Features that needs a full manual QA prior to being added to a release. team-portfolio labels Jan 10, 2025
@ziad-saab ziad-saab marked this pull request as ready for review January 13, 2025 20:30
@ziad-saab ziad-saab requested a review from a team as a code owner January 13, 2025 20:30
@ziad-saab ziad-saab added No E2E Smoke Needed If the PR does not need E2E smoke test run QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jan 13, 2025
@ziad-saab ziad-saab marked this pull request as draft January 13, 2025 20:56
@ziad-saab ziad-saab marked this pull request as ready for review January 13, 2025 21:49
@ziad-saab ziad-saab added Run Smoke E2E Triggers smoke e2e on Bitrise and removed No E2E Smoke Needed If the PR does not need E2E smoke test run labels Jan 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 13, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4af548d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/258a6bb8-0746-4cdf-aa7b-051017c7d197

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@ziad-saab ziad-saab removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 14, 2025
@ziad-saab ziad-saab requested a review from Cal-L January 15, 2025 22:18
@ziad-saab ziad-saab added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 752b82e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d5c94e76-c4d3-4a6c-b475-5dc5dda7355a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@ziad-saab ziad-saab added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ea59d96
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e84b93a4-41ca-48a1-b8b9-4cbd0c10ae66

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@ziad-saab ziad-saab disabled auto-merge January 16, 2025 17:38
@metamaskbot metamaskbot requested a review from a team as a code owner January 16, 2025 18:48
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
87.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ziad-saab ziad-saab added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 17, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 698e9dd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/681a255b-0298-443c-89da-48883043a55f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@ziad-saab ziad-saab added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 17, 2025
@Cal-L
Copy link
Contributor

Cal-L commented Jan 17, 2025

Are the e2e failures on your end or on main?

@Cal-L Cal-L added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cal-L Cal-L Awaiting requested review from Cal-L

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done Run Smoke E2E Triggers smoke e2e on Bitrise team-portfolio
Projects
PR review queue
Status: Needs dev review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ziad-saab @Cal-L @metamaskbot