Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add networkClientId to estimateGas function #12958

Conversation

OGPoyraz
Copy link
Member

Description

This PR aims to add networkClientId argument to estimateGas function.

Related issues

Fixes: #12612

Manual testing steps

  1. Try sending non-native asset initiated from app
  2. See no "Instricted gas too low" error
  3. Expect transaction to be passed

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jan 13, 2025
@OGPoyraz OGPoyraz requested review from a team as code owners January 13, 2025 14:49
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jan 13, 2025
@OGPoyraz OGPoyraz enabled auto-merge January 13, 2025 15:47
@sleepytanya
Copy link
Contributor

sleepytanya commented Jan 13, 2025

Bitrise build: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/244ae70f-9274-47b5-9cad-95f7764ff4b3?tab=workflows

Native and non-native tokens can be successfully send on all Popular networks:

iOS:

ScreenRecording_01-13-2025.12-22-33_1.MP4

Android:

Screen_Recording_20250113_130105_MetaMask.mp4

@sleepytanya sleepytanya added the QA Passed A successful QA run through has been done label Jan 13, 2025
@OGPoyraz OGPoyraz removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jan 13, 2025
@OGPoyraz OGPoyraz added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit 99a2404 Jan 13, 2025
44 of 49 checks passed
@OGPoyraz OGPoyraz deleted the 12612-bug-intrinsic-gas-too-low-internal-json-rpc-intrinsic-gas-exceeds-gas-limit-for-linea-error-when-sending-non-native-tokens-on-all-popular-networks branch January 13, 2025 18:50
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2025
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Jan 13, 2025
@Unik0rnMaggie
Copy link
Contributor

Fix works for both sending non-native tokens and ERC721 tokens:

Send.non-native.tokens.mov
send.ERC721.mov

Small issue noted: after sending the NFT, the MM app closes

@sleepytanya
Copy link
Contributor

@Unik0rnMaggie Can't reproduce issue with ERC 721 as 'Next' is disabled for me

@Unik0rnMaggie
Copy link
Contributor

Thank you very much @sleepytanya ! It seems you are experiencing this bug

I'm also not sure why using the build from this fix it works to send NFTs, and using the latest RC build i'm still experiencing the errors

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-7.39.0 Issue or pull request that will be included in release 7.39.0 team-confirmations Push issues to confirmations team
Projects
None yet
6 participants