-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add networkClientId
to estimateGas
function
#12958
Conversation
Quality Gate passedIssues Measures |
Bitrise build: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/244ae70f-9274-47b5-9cad-95f7764ff4b3?tab=workflows Native and non-native tokens can be successfully send on all Popular networks: iOS: ScreenRecording_01-13-2025.12-22-33_1.MP4Android: Screen_Recording_20250113_130105_MetaMask.mp4 |
Fix works for both sending non-native tokens and ERC721 tokens: Send.non-native.tokens.movsend.ERC721.movSmall issue noted: after sending the NFT, the MM app closes |
@Unik0rnMaggie Can't reproduce issue with ERC 721 as 'Next' is disabled for me |
Thank you very much @sleepytanya ! It seems you are experiencing this bug I'm also not sure why using the build from this fix it works to send NFTs, and using the latest RC build i'm still experiencing the errors |
Description
This PR aims to add
networkClientId
argument toestimateGas
function.Related issues
Fixes: #12612
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist