Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(12758): As requested, replace logging with swallowed error. #12996

Conversation

EtherWizard33
Copy link
Contributor

@EtherWizard33 EtherWizard33 commented Jan 15, 2025

Description

It seems this error is 'expected', and was creating unnecessary traffic on sentry which is intended for errors. This PR brings back the logic to what it was initially, which swallowed the error.

Related issues

Fixes: #12758

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

It seems this error is 'expected', and was creating traffic on sentry which is intended for errors.
@EtherWizard33 EtherWizard33 added No QA Needed Apply this label when your PR does not need any QA effort. team-wallet-ux labels Jan 15, 2025
@EtherWizard33 EtherWizard33 requested a review from a team as a code owner January 15, 2025 10:00
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@EtherWizard33 EtherWizard33 added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to improve error handling. Suppressing errors with no logging and no type check is almost never optimal; we should avoid this pattern as a general rule.

@EtherWizard33
Copy link
Contributor Author

Closing PR after conversation in slack:

Screenshot 2025-01-17 at 5 37 04 PM

@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sentry] Error: Subject "[some URL]" has no permission for "endowment:permitted-chains".
4 participants