Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make message section on re-designed signature pages scrollable #12998

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jan 15, 2025

Description

As scroll to message section on re-designed signature request pages.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3915

Manual testing steps

  1. Enable re-designs locally
  2. Submit signature request
  3. Check scroll in expanded message section

Screenshots/Recordings

Screen.Recording.2025-01-15.at.3.39.14.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Jan 15, 2025
@jpuri jpuri requested a review from a team as a code owner January 15, 2025 10:16
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.83%. Comparing base (6b68dd7) to head (b0cf73c).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12998      +/-   ##
==========================================
+ Coverage   59.72%   59.83%   +0.10%     
==========================================
  Files        1865     1873       +8     
  Lines       42011    42121     +110     
  Branches     5458     5473      +15     
==========================================
+ Hits        25093    25201     +108     
+ Misses      15239    15238       -1     
- Partials     1679     1682       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 15, 2025
Copy link
Contributor

github-actions bot commented Jan 15, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b0cf73c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/13225477-f83c-47b8-b82d-547c75b24f21

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jpuri jpuri added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit 4e7a190 Jan 15, 2025
43 of 46 checks passed
@jpuri jpuri deleted the msg_section_scroll_fix branch January 15, 2025 10:53
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2025
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants