feat: mobile push notifications #13006
Draft
+1,008
−768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO - must update segment-schema repo for this to be available in MXP
- remove coupling notification services with these managers/services - remove notification service types from the transaction notification types - tidy FCMService to match extension/CORE - remove coupling from the notifee NotificationService file.
update types, and add correct push interface
This is now done in the controller. The push click handler may need to be done through UI though.
remove old code
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
Comment on lines
40
to
41
| // TODO - Find out how to handle clicking notifications in the background. | ||
| // The only approach notifee + navigate offers is through React. |
There was a problem hiding this comment.
Notifee + ReactNavigation offers react bindings for clicking notifications, but I don't see non-react bindings.
2 Approaches:
- We use a react approach and invoke a hook at root.
- There are "Deep Links" that we can add to IOS and Android settings to prompt what page/view the application should open up into.
- Fallback - we can just open the home page worst case.
contains some fixes we found that needed to be added to the package
…add-controller-push-notifications
…add-controller-push-notifications
…add-controller-push-notifications
…add-controller-push-notifications
ensures that notifications are enabled before we register for push notifications
…ot enabled I don't really like this, I think we might need to actually decouple notifications from push notifications?
remove some actions that are unused, and add some comments to come back to
…add-controller-push-notifications
…add-controller-push-notifications
remove unused methods, and add tests
…add-controller-push-notifications
…add-controller-push-notifications
notifee can only store string objects
we forgot to update some allowed actions and events
this prevents the app from being fully rendered if in headless mode
I dont think this is necessary anymore
we don't need to call it from the index.js file
this matches notifee notifications to give some similarities for foreground/background/killed notifications
…add-controller-push-notifications
these changes are not needed as IOS does not run in expo
Prithpal-Sooriya
force-pushed
the
feat/add-controller-push-notifications
branch
from
609d5ce to
84ec599
Compare
this has issues for both android and ios, so instead our server will send a notification payload
Comment on lines
+885
to
+890
| PUSH_NOTIFICATIONS_RECEIVED: generateOpt( | ||
| EVENT_NAME.PUSH_NOTIFICATIONS_RECEIVED, | ||
| ), | ||
| PUSH_NOTIFICATIONS_CLICKED: generateOpt( | ||
| EVENT_NAME.PUSH_NOTIFICATIONS_CLICKED, | ||
| ), |
There was a problem hiding this comment.
I'm removing these events for mobile, they are not feasible.
Context:
Mobile background and killed push notifications currently will not run headless JS for us to then intercept and send events for receive and clicks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for mobile push notifications. Reorganised some services, and utilising the shared controller over custom logic.
Draft TODO:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist