-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tokens list to display with hideTokensWithoutBalance setting #13007
base: main
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: 4f8b3e4 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure if this is the expected behavior, and it won't align with the behavior on extension.
I'm flagging this until we come to a decision with Product 👍
Bitrise✅✅✅ Commit hash: 646b0d5 Note
|
Bitrise✅✅✅ Commit hash: 26e12d1 Note
|
Quality Gate passedIssues Measures |
Description
PR to fix an issue with the tokenList showing the msg "You don't have any tokens" when popular networks is selected and the setting HideTokensWithoutBalance is enabled
Related issues
Fixes: #13025
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2025-01-16.at.10.30.15.mov
Pre-merge author checklist
Pre-merge reviewer checklist