Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add earn button to wallet actions #13018

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: add earn button to wallet actions #13018

wants to merge 7 commits into from
+149 −11

Conversation

nickewansmith
Copy link
Contributor

@nickewansmith nickewansmith commented Jan 15, 2025 •
edited
Loading

Description

  1. What is the reason for the change?

We want to add a wallet action button for Earn to make it easy for users to find

  1. What is the improvement/solution?

Add Earn button to wallet actions and make sure that on click we switch to mainnet if we are on a staking unsupported network

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/STAKE-897

Manual testing steps

  • Turn the MM_STABLECOIN_LENDING_UI_ENABLED flag on
  • Go to wallet actions on mainnet, click Earn and you should go to staking page for mainnet
  • Go to wallet actions on holesky, click Earn and you should go to staking page for holesky
  • Go to wallet actions on any other network, click Earn and you should go to staking page for mainnet

Screenshots/Recordings

Before

Screenshot 2025-01-15 at 6 42 58 PM

After

Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2025-01-15.at.18.44.00.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@nickewansmith nickewansmith marked this pull request as ready for review January 16, 2025 17:15
@nickewansmith nickewansmith requested review from a team as code owners January 16, 2025 17:15
@amitabh94
Copy link
Contributor

@nickewansmith Do you think we should place this behind the stablecoin feature flag ?
Overall LGTM!

@nickewansmith
Copy link
Contributor Author

@nickewansmith Do you think we should place this behind the stablecoin feature flag ? Overall LGTM!

Yes, thanks!

@nickewansmith nickewansmith force-pushed the STAKE-897-fe-add-earn-button-to-main-wallet-actions branch from ac330f6 to 5d4750c Compare January 16, 2025 17:29
@nickewansmith nickewansmith added Run Smoke E2E Triggers smoke e2e on Bitrise needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jan 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: fc3e65e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cd695b73-c243-428d-b3ad-a1cf4fe6e25e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

amitabh94
amitabh94 previously approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@amitabh94 amitabh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nickewansmith
Copy link
Contributor Author

Updated to use Plant.svg

@nickewansmith nickewansmith added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5818fa4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bbca5658-3dbc-4225-b9e6-4627d8c51a8e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitabh94 amitabh94 Awaiting requested review from amitabh94

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Triggers smoke e2e on Bitrise team-stake
Projects
PR review queue
Status: Needs dev review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickewansmith @amitabh94 @metamaskbot