Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: revert noBorder Ramp Box param and replace Ramp Box usage in SimulationValueDisplay with View #13033

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

digiwand
Copy link
Contributor

Description

revert noBorder Ramp Box param and replace Ramp Box usage in SimulationValueDisplay with View

Related issues

Fixes: #13013

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested review from a team as code owners January 16, 2025 15:30
@digiwand digiwand added the team-confirmations Push issues to confirmations team label Jan 16, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@digiwand digiwand added the DO-NOT-MERGE Pull requests that should not be merged label Jan 16, 2025
@digiwand
Copy link
Contributor Author

do not merge until #12994 is merged to avoid merge conflicts

@digiwand digiwand added Run Smoke E2E Triggers smoke e2e on Bitrise and removed DO-NOT-MERGE Pull requests that should not be merged labels Jan 16, 2025
Copy link
Contributor

github-actions bot commented Jan 16, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1dffc13
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/91935a6d-8cab-4ce0-aa9c-f4cd3c94307f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@wachunei
Copy link
Member

wachunei commented Jan 16, 2025

LGTM, I will approve once conflicts are resolved.

@digiwand
Copy link
Contributor Author

thank you! resolved @wachunei

@digiwand digiwand requested a review from wachunei January 16, 2025 16:02
@digiwand digiwand enabled auto-merge January 16, 2025 16:05
@digiwand digiwand added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit f27dbe6 Jan 16, 2025
37 checks passed
@digiwand digiwand deleted the refactor-revert-noBorder-ramp-box-param branch January 16, 2025 16:24
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Ramp/Box instances with View in confirmations components
3 participants