test: Remove testHelpers file

[cortisiko]

Description

The helpers.js file was a bit of a dumping ground for all test actions: Selecting elements, asserting elements, and using utility methods like delays, deep linking, launching the app, and interacting with elements. We did some work last year to separate the various types of logic.

Locating elements - Matchers.js
Interacting with elements - Guestures.js
Asserting elements - Assertions.js

They all live in the e2e/utils folder.

The purpose of this PR is to remove all instances where the helper's file is used and to move the remaining utility methods: launch the app, open deep link, and delay to the main utility class. With this PR merged, we can avoid engineers using anti-patterns within the e2e framework. Now, the codebase will strictly abide by our test guidelines.

Because the helpers.js file existed in nearly all of our page objects, the PR might seem significant, but it is not. Many changes are either 2-3 lines in each file. I will do my self-review so that others can understand what changed.

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud