Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove device constraint from isPortfolioViewEnabled feature flag #13058

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Jan 17, 2025

Description

Re-enable PV on Android devices.

Related issues

Original PR: #13039

Manual testing steps

Run app with feature flag: PORTFOLIO_VIEW='true' yarn watch:clean
On iOS device, PortfolioView should be enabled
On Android device, PortfolioView should be enabled

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish marked this pull request as ready for review January 17, 2025 16:11
@gambinish gambinish requested a review from a team as a code owner January 17, 2025 16:11
@gambinish gambinish added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 17, 2025
Copy link
Contributor

github-actions bot commented Jan 17, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c241af8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d32177f9-56dc-465f-b68c-a1391f3986d1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@gambinish gambinish added this pull request to the merge queue Jan 17, 2025
@gambinish gambinish removed this pull request from the merge queue due to a manual request Jan 17, 2025
@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 17, 2025
@gambinish gambinish added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 3822bda Jan 17, 2025
51 of 53 checks passed
@gambinish gambinish deleted the fix/enable-pv-on-android branch January 17, 2025 18:54
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.40.0 Issue or pull request that will be included in release 7.40.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants