Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply migration 66 #13066

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: apply migration 66 #13066

wants to merge 1 commit into from

Conversation

owencraston
Copy link
Contributor

@owencraston owencraston commented Jan 18, 2025

Description

Migration 66 was created in this PR but was not applied in the index file. This PR patches that by adding it into the index file so that it can be applied to users upgrading their wallet.

Related issues

Fixes:

Manual testing steps

  1. run the app on a device that had an old version of the app
  2. check this branch and re run the app after a yarn setup
  3. the app should load with no errors
  4. all account should still be present in the app with the custom names applied

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@owencraston owencraston marked this pull request as ready for review January 18, 2025 01:33
@owencraston owencraston requested a review from a team as a code owner January 18, 2025 01:33
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@owencraston owencraston added Run Smoke E2E Triggers smoke e2e on Bitrise and removed team-accounts labels Jan 18, 2025
Copy link
Contributor

github-actions bot commented Jan 18, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 637d91c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/820123fb-a2a9-4218-99be-800052c3ee49

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@httpJunkie httpJunkie self-requested a review January 18, 2025 01:36
@owencraston owencraston changed the title patch: apply migration 66 fix: apply migration 66 Jan 18, 2025
Copy link

@httpJunkie httpJunkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG~!

@owencraston owencraston enabled auto-merge January 18, 2025 01:44
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.98%. Comparing base (faf5340) to head (637d91c).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13066      +/-   ##
==========================================
+ Coverage   59.83%   59.98%   +0.14%     
==========================================
  Files        1873     1890      +17     
  Lines       42121    42450     +329     
  Branches     5473     5593     +120     
==========================================
+ Hits        25204    25463     +259     
- Misses      15235    15260      +25     
- Partials     1682     1727      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@owencraston
Copy link
Contributor Author

owencraston commented Jan 18, 2025

regression e2e tests 🟢

@owencraston owencraston added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants