Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setApprovalForAll nonce too low #13142

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

digiwand
Copy link
Contributor

Description

I believe this fixes the issue based on previous fix #6592. This previous fix was undone about 7 months ago. The issue may have existed since the 7.26 release

Related issues

Fixes: #13069

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested a review from a team as a code owner January 23, 2025 14:31
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jan 23, 2025
@digiwand digiwand added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 23, 2025
Copy link
Contributor

github-actions bot commented Jan 23, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 612e9d1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/db97cee8-1aac-45ba-919c-d18f4938dcc7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sleepytanya
Copy link
Contributor

Bitrise build https://app.bitrise.io/build/d29cbe43-8270-47d0-b68d-28bc087a85db?tab=artifacts

Samsung S24+

Set Approval for All from the device works as expected:

Screen_Recording_20250123_102826_MetaMask.mp4

Set Approval for All from Ledger also works perfect:

ledger.mp4

@sleepytanya sleepytanya added the QA Passed A successful QA run through has been done label Jan 23, 2025
@digiwand digiwand added this pull request to the merge queue Jan 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 23, 2025
@digiwand digiwand added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit 9c39bb6 Jan 24, 2025
46 of 49 checks passed
@digiwand digiwand deleted the fix-nonce-too-low-setApprovalForAll-ledger branch January 24, 2025 13:40
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 24, 2025
@digiwand digiwand added release-7.39.0 Issue or pull request that will be included in release 7.39.0 rc-cherry-picked and removed release-7.40.0 Issue or pull request that will be included in release 7.40.0 labels Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done rc-cherry-picked release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
4 participants