fix: move migration validation out of onPersistComplete

[owencraston]

Description

• The issue now seems to be that onPersistComplete is not only called after migrations run, they are called even for new users so we are seeing errors logged to sentry that do not pertain to existing users.

• In this PR I hope to only run the migration validation after after we have completed all the migrations. This should only happen when a user updates the app.

Related issues

Fixes: #13144

Manual testing steps

1. Download an old version of the app
2. create accounts (ideally ones that have tokens)
3. Update to this version of the app
4. there should be no crashes

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0bd3016
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6b523b41-50cf-4685-b593-15ec43ee0102

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[owencraston]

e2e regression pipeline: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4cb5c2cd-1c82-41cf-a636-19f821c1a282?tab=workflows

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ac67868
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/66e1399e-a316-407d-89c9-d4cdda6237ee

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sethkfman]

LGTM