Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update token balances on pull tokenlist pull down #13208

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Jan 27, 2025

Description

PR to add updating balances as part of pulling down on the tokenList

Related issues

Fixes:

Manual testing steps

  1. Make a swap between any 2 tokens
  2. Go back to home page and notice your balance is not updated for the two tokens.
  3. Pull down on the tokenList
  4. Your balances should now be refreshed

Screenshots/Recordings

Before

After

Screen.Recording.2025-01-27.at.21.16.09.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 27, 2025
@sahar-fehri sahar-fehri marked this pull request as ready for review January 27, 2025 20:13
@sahar-fehri sahar-fehri requested a review from a team as a code owner January 27, 2025 20:13
Copy link
Contributor

github-actions bot commented Jan 27, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6481a7a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6c3470f5-d93d-4ed4-b7b9-75bf7bea0aa4

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link
Contributor

@gambinish gambinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected. I left a comment on your thread about something that I think we should keep in mind.

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 28, 2025
Copy link
Contributor

github-actions bot commented Jan 28, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ef7f392
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dccb33fb-a8ac-4a06-a230-78bd61390130

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 28, 2025
@sahar-fehri sahar-fehri added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit 8c3f395 Jan 30, 2025
39 checks passed
@sahar-fehri sahar-fehri deleted the fix/refresh-balances-on-pullDown-tokenList branch January 30, 2025 14:20
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-7.40.0 Issue or pull request that will be included in release 7.40.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants