Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump notification controller package #13266

Closed
wants to merge 1 commit into from
Closed

feat: bump notification controller package #13266

wants to merge 1 commit into from
+383 −305

Conversation

Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Jan 30, 2025 •
edited
Loading

Description

Bump notifications controller from ^0.15.0 to ^0.17.0

Related issues

Fixes: Removes the audit resolution added here - #13197

Manual testing steps

N/A - as the notifications feature has not shipped yet.

Just need to confirm that the application compiles without any audit issues.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Prithpal-Sooriya Prithpal-Sooriya force-pushed the feat/update-notification-controller-package branch from 9c8f44c to 9a8bb9e Compare January 30, 2025 12:37
@metamaskbot metamaskbot added the team-notifications DEPRECATED: Use "team-assets" instead label Jan 30, 2025
@Prithpal-Sooriya Prithpal-Sooriya added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 30, 2025
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 9a8bb9e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/07bde514-6f47-4f6b-914f-67e8f45d57d7

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@socket-security Socket Security
Copy link

socket-security bot commented Jan 30, 2025 •
edited
Loading

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 50.2 kB chholland, feiyang.chen, firebase-ops, ...1 more
npm/@firebase/[email protected] None 0 21.2 kB google-wombot
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 483 kB chholland, feiyang.chen, firebase-ops, ...1 more
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 39.4 kB google-wombot
npm/@firebase/[email protected] None 0 2.9 kB google-wombot
npm/@firebase/[email protected] None 0 5.34 kB google-wombot
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 447 kB chholland, feiyang.chen, firebase-ops, ...1 more
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 176 kB google-wombot
npm/@firebase/[email protected] None 0 9.56 kB google-wombot
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 382 kB chholland, feiyang.chen, firebase-ops, ...1 more
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 1.48 MB chholland, feiyang.chen, firebase-ops, ...1 more
npm/@firebase/[email protected] None 0 1.97 kB google-wombot
npm/@firebase/[email protected] None 0 15.5 kB google-wombot
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 16 MB chholland, feiyang.chen, firebase-ops, ...1 more
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 119 kB chholland, feiyang.chen, firebase-ops, ...1 more
npm/@firebase/[email protected] environment, network 0 615 kB google-wombot
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 2.28 MB chholland, feiyang.chen, firebase-ops, ...1 more
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 6.26 kB chholland, feiyang.chen, firebase-ops, ...1 more
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 8.7 MB chholland, feiyang.chen, firebase-ops, ...1 more
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 690 kB chholland, feiyang.chen, firebase-ops, ...1 more
npm/@firebase/[email protected] None 0 13.6 kB google-wombot
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 28.2 MB chholland, feiyang.chen, firebase-ops, ...1 more
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 36.7 kB chholland, feiyang.chen, firebase-ops, ...1 more
npm/@firebase/[email protected] None 0 6.15 kB google-wombot
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 248 kB chholland, feiyang.chen, firebase-ops, ...1 more
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 26.2 kB chholland, feiyang.chen, firebase-ops, ...1 more
npm/@firebase/[email protected] None 0 2.34 kB google-wombot
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 337 kB chholland, feiyang.chen, firebase-ops, ...1 more
npm/@firebase/[email protected] None 0 54.8 kB google-wombot
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 41.2 kB chholland, feiyang.chen, firebase-ops, ...1 more
npm/@firebase/[email protected] None 0 1.87 kB google-wombot
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 785 kB chholland, feiyang.chen, firebase-ops, ...1 more
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 27.7 kB chholland, feiyang.chen, firebase-ops, ...1 more
npm/@firebase/[email protected] None 0 4.56 kB google-wombot
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 425 kB chholland, feiyang.chen, firebase-ops, ...1 more
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 38.3 kB chholland, feiyang.chen, firebase-ops, ...1 more
npm/@firebase/[email protected] None 0 6.26 kB chholland, feiyang.chen, firebase-ops, ...1 more
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 396 kB chholland, feiyang.chen, firebase-ops, ...1 more
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 127 kB chholland, feiyang.chen, firebase-ops, ...1 more
npm/@firebase/[email protected] None 0 6.41 kB google-wombot
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 2.18 MB chholland, feiyang.chen, firebase-ops, ...1 more
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 923 kB google-wombot
npm/@firebase/[email protected] network 0 896 kB google-wombot
npm/@firebase/[email protected] 🔁 npm/@firebase/[email protected] None 0 365 kB google-wombot
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] None 0 1.38 MB metamaskbot
npm/[email protected] 🔁 npm/[email protected] None 0 24.6 MB google-wombot

🚮 Removed packages: npm/@firebase/[email protected]

View full report↗︎

@socket-security Socket Security
Copy link

socket-security bot commented Jan 30, 2025 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@firebase/[email protected], npm/@firebase/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@Prithpal-Sooriya
Copy link
Contributor Author

Prithpal-Sooriya commented Jan 30, 2025 •
edited
Loading

@SocketSecurity ignore npm/@firebase/[email protected] npm/@firebase/[email protected] these are packages we do not use.

Unfortunately the npm firebase does not have a recommended way of installing only the submodules we use (firebase/messaging) and instead adds all submodules of this package.

@Prithpal-Sooriya Prithpal-Sooriya force-pushed the feat/update-notification-controller-package branch from 9a8bb9e to 857cbfc Compare January 30, 2025 12:47
@Prithpal-Sooriya Prithpal-Sooriya added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 30, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 857cbfc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/61ad89b3-2890-4767-a32b-09ef6580e656

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Prithpal-Sooriya
Copy link
Contributor Author

Unfortunately react-native-firebase still uses an old version of firebase, so this resolution cannot be resolved until this package is updated here: https://github.com/invertase/react-native-firebase/blob/main/packages/app/package.json

@Prithpal-Sooriya
Copy link
Contributor Author

Closing this package as we plan to do this package upgrade in another PR.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-notifications DEPRECATED: Use "team-assets" instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Prithpal-Sooriya @metamaskbot