Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(runway): cherry-pick fix: metrics call during onboarding #13284

Merged
merged 1 commit into from
Jan 30, 2025
+19 −5
Merged

chore(runway): cherry-pick fix: metrics call during onboarding #13284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/components/Views/AccountBackupStep1/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import { useTheme } from '../../../util/theme';
import { ManualBackUpStepsSelectorsIDs } from '../../../../e2e/selectors/Onboarding/ManualBackUpSteps.selectors';
import trackOnboarding from '../../../util/metrics/TrackOnboarding/trackOnboarding';
import Routes from '../../../../app/constants/navigation/Routes';
import { MetricsEventBuilder } from '../../../core/Analytics/MetricsEventBuilder';

const createStyles = (colors) =>
StyleSheet.create({
Expand Down Expand Up @@ -129,7 +130,9 @@ const AccountBackupStep1 = (props) => {
const styles = createStyles(colors);

const track = (event, properties) => {
trackOnboarding(event, properties);
const eventBuilder = MetricsEventBuilder.createEventBuilder(event);
eventBuilder.addProperties(properties);
trackOnboarding(eventBuilder.build());
};

useEffect(() => {
Expand Down
5 changes: 4 additions & 1 deletion app/components/Views/ChoosePassword/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ import navigateTermsOfUse from '../../../util/termsOfUse/termsOfUse';
import { ChoosePasswordSelectorsIDs } from '../../../../e2e/selectors/Onboarding/ChoosePassword.selectors';
import trackOnboarding from '../../../util/metrics/TrackOnboarding/trackOnboarding';
import { enableProfileSyncing } from '../../../actions/identity';
import {MetricsEventBuilder} from '../../../core/Analytics/MetricsEventBuilder';
const createStyles = (colors) =>
StyleSheet.create({
mainWrapper: {
Expand Down Expand Up @@ -256,7 +257,9 @@ class ChoosePassword extends PureComponent {
keyringControllerPasswordSet = false;

track = (event, properties) => {
trackOnboarding(event, properties);
const eventBuilder = MetricsEventBuilder.createEventBuilder(event);
eventBuilder.addProperties(properties);
trackOnboarding(eventBuilder.build());
};

updateNavBar = () => {
Expand Down
5 changes: 4 additions & 1 deletion app/components/Views/ImportFromSecretRecoveryPhrase/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ import { ImportFromSeedSelectorsIDs } from '../../../../e2e/selectors/Onboarding
import { ChoosePasswordSelectorsIDs } from '../../../../e2e/selectors/Onboarding/ChoosePassword.selectors';
import trackOnboarding from '../../../util/metrics/TrackOnboarding/trackOnboarding';
import { useProfileSyncing } from '../../../util/identity/hooks/useProfileSyncing';
import {MetricsEventBuilder} from '../../../core/Analytics/MetricsEventBuilder';

const MINIMUM_SUPPORTED_CLIPBOARD_VERSION = 9;

Expand Down Expand Up @@ -108,7 +109,9 @@ const ImportFromSecretRecoveryPhrase = ({
const confirmPasswordInput = React.createRef();

const track = (event, properties) => {
trackOnboarding(event, properties);
const eventBuilder = MetricsEventBuilder.createEventBuilder(event);
eventBuilder.addProperties(properties);
trackOnboarding(eventBuilder.build());
};

const updateNavBar = () => {
Expand Down
6 changes: 5 additions & 1 deletion app/components/Views/ManualBackupStep3/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,11 @@ class ManualBackupStep3 extends PureComponent {
SEED_PHRASE_HINTS,
JSON.stringify({ ...parsedHints, manualBackup: hintText }),
);
this.track(MetaMetricsEvents.WALLET_SECURITY_RECOVERY_HINT_SAVED);
trackOnboarding(
MetricsEventBuilder.createEventBuilder(
MetaMetricsEvents.WALLET_SECURITY_RECOVERY_HINT_SAVED,
).build(),
);
};

done = async () => {
Expand Down
3 changes: 2 additions & 1 deletion app/components/Views/Onboarding/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ import Routes from '../../../constants/navigation/Routes';
import { selectAccounts } from '../../../selectors/accountTrackerController';
import trackOnboarding from '../../../util/metrics/TrackOnboarding/trackOnboarding';
import { trace, TraceName, TraceOperation } from '../../../util/trace';
import { MetricsEventBuilder } from '../../../core/Analytics/MetricsEventBuilder';

const createStyles = (colors) =>
StyleSheet.create({
Expand Down Expand Up @@ -321,7 +322,7 @@ class Onboarding extends PureComponent {
};

track = (event) => {
trackOnboarding(event);
trackOnboarding(MetricsEventBuilder.createEventBuilder(event).build());
};

alertExistingUser = (callback) => {
Expand Down
Loading