Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust browser display when multiple tabs are present #13294

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

ziad-saab
Copy link
Contributor

Description

This PR fixes the browser view when multiple tabs are open

Related issues

Fixes:

Manual testing steps

  1. Go to the browser
  2. Open multiple tabs
  3. Observe that the view doesn't get pushed down

Screenshots/Recordings

Before

image (notice that there are two tabs open)

After

image (notice that there are two tabs open)

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@ziad-saab ziad-saab requested a review from a team as a code owner January 31, 2025 15:09
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Jan 31, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f9350f0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3ab197ce-b163-49d6-885d-fcbcee76562f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@ziad-saab
Copy link
Contributor Author

Team label PR here >> https://github.com/MetaMask/MetaMask-planning/pull/4085

@ziad-saab ziad-saab added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 31, 2025
@ziad-saab ziad-saab changed the base branch from release/7.40.0 to main January 31, 2025 15:30
@ziad-saab ziad-saab requested a review from a team as a code owner January 31, 2025 15:30
@ziad-saab ziad-saab force-pushed the zs/fix-browser-tabs branch from f9350f0 to fd863ea Compare January 31, 2025 15:31
@joaoloureirop joaoloureirop added No E2E Smoke Needed If the PR does not need E2E smoke test run and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 31, 2025
@joaoloureirop joaoloureirop added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit 411bad5 Jan 31, 2025
43 checks passed
@joaoloureirop joaoloureirop deleted the zs/fix-browser-tabs branch January 31, 2025 16:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2025
@metamaskbot metamaskbot added the release-7.41.0 Issue or pull request that will be included in release 7.41.0 label Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run QA Passed A successful QA run through has been done release-7.41.0 Issue or pull request that will be included in release 7.41.0 team-portfolio
Projects
None yet
3 participants