feat(off-ramp): add off-ramp feature #7037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
wachunei
force-pushed
the
feat/off-ramp
branch
from
d2ac4af to
afdec53
Compare
3 tasks
<!-- Thanks for your contribution! Please ensure that any applicable requirements below are satisfied before submitting this pull request. This will help ensure a quick and efficient review cycle. --> **Development & PR Process** 1. Follow MetaMask [Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/coding_guidelines/CODING_GUIDELINES.md) 2. Add `release-xx` label to identify the PR slated for a upcoming release (will be used in release discussion) 3. Add `needs-dev-review` label when work is completed 4. Add the appropiate QA label when dev review is completed - `needs-qa`: PR requires manual QA. - `No QA/E2E only`: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise. - `Spot check on release build`: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested. 5. Add `QA Passed` label when QA has signed off (Only required if the PR was labeled with `needs-qa`) 6. Add your team's label, i.e. label starting with `team-` (or `external-contributor` label if your not a MetaMask employee) **Description** This PR renames the "Amount To Buy" View to "Build Quote". It also extracts the logic for crypto currencies, fiat currencies and limits into hooks. These hooks in the future will accept a ramp type value, either buy or sell. **Screenshots/Recordings** ~~_If applicable, add screenshots and/or recordings to visualize the before and after of your change_~~ **Issue** fixes #??? **Checklist** * [ ] There is a related GitHub issue * [ ] Tests are included if applicable * [ ] Any added code is fully documented --------- Co-authored-by: Pedro Pablo Aste Kompen <[email protected]>
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Co-authored-by: Pedro Pablo Aste Kompen <[email protected]>
## **Description** Adds analytics events to the offramp flow to track when the user attempts, succeeds or cancels the the transaction which will send funds to the provider. ## **Related issues** N/A ## **Manual testing steps** Verify the analytics events are called by checking logs when navigating through the transaction flow ## **Screenshots/Recordings** n/a ### **Before** n/a ### **After** n/a ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Pedro Pablo Aste Kompen <[email protected]>
Co-authored-by: George Weiler <[email protected]>
15 tasks
|
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ac1736b4-3672-42e1-978f-d220c7f0835f |
|
@wachunei Add figma documentation for expected behavior |
|
@sethkfman We have added a new PR with a fix during QA #7872 |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@wachunei @georgeweiler LGTM I finished verifying iOS and Android with the latest changes ✅ |
wachunei
added
ramp-qa-passed
and removed
needs-ramp-qa
metamaskbot
added
the
release-7.12.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains the off-ramp feature and is a collection of the work of multiple other PRs. PRs that have been reviewed and approved by MetaMask members are marked as "✅ Approved".
Merged and Open PRs
common,buy,sellfolders #7014 - ApprovedDraft PRs
Design Document
https://www.figma.com/file/PsKqriAOpJDQpaHt373D45/Off-Ramp?type=design&node-id=3227-193475&mode=design&t=RY1XXYsSUIkqG1Di-0
Related issues
Refer to each PR
Manual testing steps
Refer to each PR
Screenshots/Recordings
Refer to each PR
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist