-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: UX improvement to address blockaid performance issue #7680
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…Mask/metamask-mobile into blockaid_performance_ux_improvement
…Mask/metamask-mobile into blockaid_performance_ux_improvement
…Mask/metamask-mobile into blockaid_performance_ux_improvement
…Mask/metamask-mobile into blockaid_performance_ux_improvement
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7680 +/- ##
==========================================
+ Coverage 35.06% 35.13% +0.07%
==========================================
Files 1034 1036 +2
Lines 27532 27576 +44
Branches 2302 2315 +13
==========================================
+ Hits 9653 9689 +36
- Misses 17362 17367 +5
- Partials 517 520 +3
☔ View full report in Codecov by Sentry. |
68ce6d6
to
9206342
Compare
…Mask/metamask-mobile into blockaid_performance_ux_improvement
Kudos, SonarCloud Quality Gate passed! |
Description
UX improvement for blockaid performance issue. Currently we intervene incoming transaction and blockaid UI rendering till request is validated. With the change validation is made an async background process so UI loading is not blocked for it.
Related issues
Fixes: #7521
Manual testing steps
Screenshots/Recordings
Screen.Recording.2023-11-07.at.9.16.51.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist