feat: Network verification changed

[tommasini]

Description

This PR aims to update network verification UI to help the user with more warnings when adding a custom network via dapp.

Related issues

Fixes: #

Manual testing steps

1. Go to this chainlist.org on in app browser
2. Add a custom network
3. Should see the new layout

Screenshots/Recordings

• This recording have all the warnings for testing purposes
  https://recordit.co/QTde2ZiVrv

redirect to add custom network article
https://recordit.co/U7eo17r4qD
https://recordit.co/zywbsTqOec

Before

After

https://recordit.co/QTde2ZiVrv

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e50b8625-0b56-4721-8acd-87a6ae284a2c
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

[codecov-commenter]

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (351778e) 34.97% compared to head (616e3b0) 35.02%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7701      +/-   ##
==========================================
+ Coverage   34.97%   35.02%   +0.04%     
==========================================
  Files        1034     1035       +1     
  Lines       27529    27526       -3     
  Branches     2298     2309      +11     
==========================================
+ Hits         9629     9640      +11     
+ Misses      17387    17370      -17     
- Partials      513      516       +3     

Files	Coverage Δ
...s/Pickers/PickerNetwork/PickerNetwork.constants.ts	100.00% <100.00%> (+50.00%)	⬆️
...components/Pickers/PickerNetwork/PickerNetwork.tsx	100.00% <100.00%> (ø)
...ts/Approvals/AddChainApproval/AddChainApproval.tsx	100.00% <100.00%> (ø)
...VerificationInfo/NetworkVerificationInfo.styles.ts	100.00% <100.00%> (ø)
app/constants/urls.ts	100.00% <100.00%> (ø)
...foundation/BottomSheetDialog/BottomSheetDialog.tsx	1.53% <0.00%> (+1.53%)	⬆️
app/core/RPCMethods/wallet_addEthereumChain.js	80.37% <84.61%> (+0.37%)	⬆️
...omponents/BottomSheets/BottomSheet/BottomSheet.tsx	3.57% <0.00%> (+3.57%)	⬆️
...etworkVerificationInfo/NetworkVerificationInfo.tsx	61.11% <61.11%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[NicolasMassart]

Very clean and easy to understand code.
I pointed at some possible syntax improvements but they do not change the way the code works.
Only required change is the typo and comment to make a todo ;)

[github-actions]

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fc4f9955-2902-456b-b91c-769cb0c0b6fa
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

[github-actions]

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/63dbcc28-5bb7-4779-bdb7-1df81366a5b0
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

[github-actions]

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b08ae87f-a8cd-42e9-b964-2e7cdcf441a2
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

[Cal-L]

Left some comments

[Cal-L]

Lgtm

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

60.3% Coverage
0.0% Duplication