fix: PPOM - Malicious transactions triggered from WalletConnect are not flagged

[segun]

Description

When a malicious transaction is triggered from wallet connect, the blockaid banner alert is not shown. This is because the transaction is shown in the confirm screen after evaluation without calling PPOM.

The fix is to call PPOM before showing the transaction in the confirm screen.

Related issues

Fixes: #7707

Manual testing steps

1. Open MetaMask Mobile
2. Goto testdapp and connect via wallet connect
3. Scroll to PPOM section and click the malicious send eth
4. You will see a confirm screen on mobile without the blockaid alert
5. Checkout this branch, build and deploy on device
6. Repeat steps 2,3
7. You will see same confirm screen as 4, but now with the blockaid banner alert.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • [] In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/560d0e2c-9cdb-46ae-ae5a-1977cc3e2939
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[codecov-commenter]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (86a6593) 34.99% compared to head (92efb13) 34.99%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7725      +/-   ##
==========================================
- Coverage   34.99%   34.99%   -0.01%     
==========================================
  Files        1034     1034              
  Lines       27537    27540       +3     
  Branches     2298     2299       +1     
==========================================
  Hits         9637     9637              
- Misses      17387    17390       +3     
  Partials      513      513              

Files	Coverage Δ
app/core/WalletConnect/WalletConnectV2.ts	2.24% <0.00%> (-0.04%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.