-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update preferences controller to version ^4 #7732
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7732 +/- ##
==========================================
+ Coverage 34.99% 35.09% +0.09%
==========================================
Files 1034 1035 +1
Lines 27537 27523 -14
Branches 2298 2312 +14
==========================================
+ Hits 9637 9658 +21
+ Misses 17387 17345 -42
- Partials 513 520 +7 ☔ View full report in Codecov by Sentry. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/00c05490-ee6b-4c57-99af-3016b14eb23d |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3b91491c-5f1d-4a45-8773-179c8f278d7a |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
@SocketSecurity ignore [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Kudos, SonarCloud Quality Gate passed! |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Update the preferences controller to v^4. This part of the work of controllers update to v53
Regression testing
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/29a36162-5a5c-4484-9946-c5bd474e83ff
Related issues
Fixes: #
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist