Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update preferences controller to version ^4 #7732

Merged
merged 6 commits into from
Nov 13, 2023

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Nov 8, 2023

Description

Update the preferences controller to v^4. This part of the work of controllers update to v53

Regression testing
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/29a36162-5a5c-4484-9946-c5bd474e83ff

Related issues

Fixes: #

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Nov 8, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini changed the title feat: Update preferences controller to version ^3 feat: Update preferences controller to version ^4 Nov 8, 2023
Copy link

socket-security bot commented Nov 8, 2023

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/preferences-controller 3.0.0...4.4.3 None +0/-0 42 kB metamaskbot

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6fed1c8) 34.99% compared to head (b793c0f) 35.09%.
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7732      +/-   ##
==========================================
+ Coverage   34.99%   35.09%   +0.09%     
==========================================
  Files        1034     1035       +1     
  Lines       27537    27523      -14     
  Branches     2298     2312      +14     
==========================================
+ Hits         9637     9658      +21     
+ Misses      17387    17345      -42     
- Partials      513      520       +7     

see 66 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tommasini tommasini marked this pull request as ready for review November 9, 2023 18:25
@tommasini tommasini requested a review from a team as a code owner November 9, 2023 18:25
Copy link
Contributor

github-actions bot commented Nov 9, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/00c05490-ee6b-4c57-99af-3016b14eb23d
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@metamaskbot metamaskbot added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed in-progress labels Nov 9, 2023
Copy link
Contributor

github-actions bot commented Nov 9, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3b91491c-5f1d-4a45-8773-179c8f278d7a
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link

socket-security bot commented Nov 9, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@Cal-L
Copy link
Contributor

Cal-L commented Nov 10, 2023

@SocketSecurity ignore [email protected]

Cal-L
Cal-L previously approved these changes Nov 10, 2023
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini merged commit 45ddfde into main Nov 13, 2023
26 checks passed
@tommasini tommasini deleted the update/7728-update-preferences-controller branch November 13, 2023 21:26
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 13, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants