Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: blockaid URL #7774

Merged
merged 1 commit into from
Nov 14, 2023
Merged

fix: blockaid URL #7774

merged 1 commit into from
Nov 14, 2023

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Nov 13, 2023

Description

Blockaid URL link was broken

Related issues

Fixes: #7773

Manual testing steps

  1. Trigger a malicious transaction
  2. Click Blockaid
  3. See link is broken

Screenshots/Recordings

Before

image

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@seaona seaona added the team-confirmations-secure-ux-PR PR from the confirmations team label Nov 13, 2023
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@seaona seaona marked this pull request as ready for review November 13, 2023 11:59
@seaona seaona requested a review from a team as a code owner November 13, 2023 11:59
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9943a94e-66c1-440e-9396-7a66a3390fdf
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@seaona seaona merged commit fa2dd58 into main Nov 14, 2023
@seaona seaona deleted the fix-blockaid-link branch November 14, 2023 13:52
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: PPOM - Blockaid link is wrong and lands me to a broken page
4 participants