-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: WalletConnect requests should show loading banner for blockaid. #7776
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Signed-off-by: Akintayo A. Olusegun <[email protected]>
15cc513
to
8f8363e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7776 +/- ##
==========================================
- Coverage 35.04% 35.04% -0.01%
==========================================
Files 1040 1040
Lines 27709 27713 +4
Branches 2344 2343 -1
==========================================
Hits 9711 9711
- Misses 17474 17478 +4
Partials 524 524 ☔ View full report in Codecov by Sentry. |
Changes look good, will be great if some unit test coverage can also be added to it. |
Kudos, SonarCloud Quality Gate passed! |
Description
Make PPOM validations for deeplink and walletconnect async to leverage recent blockaid performance improvements
The changes to app/components/Views/QRScanner/index.tsx are necessary as it's a bug introduced by a recent commit. Details of the bug and the fix here
Related issues
Fixes: #1655
Screenshots/Recordings
Before
After
Then
Pre-merge author checklist
Pre-merge reviewer checklist