Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust TransactionHeader icon logic to display the dapp icon when connecting with sdk #7823

Conversation

omridan159
Copy link
Contributor

@omridan159 omridan159 commented Nov 15, 2023

…en connecting with sdk

Description

Adjust TransactionHeader icon logic to display the Dapp icon when connecting with SDK

Related issues

Fixes: #

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Screen.Recording.2023-11-15.at.14.37.32.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@omridan159 omridan159 requested a review from a team as a code owner November 15, 2023 13:07
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6168109) 35.05% compared to head (6d444ff) 35.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7823   +/-   ##
=======================================
  Coverage   35.05%   35.05%           
=======================================
  Files        1040     1040           
  Lines       27702    27702           
  Branches     2344     2344           
=======================================
  Hits         9710     9710           
  Misses      17468    17468           
  Partials      524      524           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…onHeader-icon-logic-to-display-sdk-dapp-icon
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

62.5% 62.5% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@abretonc7s abretonc7s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abretonc7s abretonc7s added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Nov 16, 2023
Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omridan159 omridan159 closed this Nov 20, 2023
@omridan159 omridan159 deleted the feat_adjust-TransactionHeader-icon-logic-to-display-sdk-dapp-icon branch November 20, 2023 09:28
@github-actions github-actions bot removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Nov 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-sdk SDK team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants