-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adjust TransactionHeader icon logic to display the dapp icon when connecting with sdk #7823
feat: adjust TransactionHeader icon logic to display the dapp icon when connecting with sdk #7823
Conversation
…en connecting with sdk
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7823 +/- ##
=======================================
Coverage 35.05% 35.05%
=======================================
Files 1040 1040
Lines 27702 27702
Branches 2344 2344
=======================================
Hits 9710 9710
Misses 17468 17468
Partials 524 524 ☔ View full report in Codecov by Sentry. |
…onHeader-icon-logic-to-display-sdk-dapp-icon
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…en connecting with sdk
Description
Adjust TransactionHeader icon logic to display the Dapp icon when connecting with SDK
Related issues
Fixes: #
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2023-11-15.at.14.37.32.mov
Pre-merge author checklist
Pre-merge reviewer checklist