Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prompt user before allowing location access #9

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

jpcloureiro
Copy link

No description provided.

@jpcloureiro
Copy link
Author

depends on #8.

ready to review after rebase

Copy link

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpcloureiro
Copy link
Author

QA passed, wait on #8 to merge

@jpcloureiro jpcloureiro merged commit 64cb789 into main Mar 26, 2024
8 checks passed
@jpcloureiro jpcloureiro deleted the location-permission-dialog branch March 26, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants