-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MEWS Front-End Test #661
Open
Lelen91
wants to merge
28
commits into
MewsSystems:master
Choose a base branch
from
Lelen91:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
MEWS Front-End Test #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add client types connect the client to react query pack everything with custom hooks
fully typed react-query queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everybody,
The submitted task reflects my perspective of what a production ready app should be considered to have.
I tried to put inside all my knowledge and stretched a bit in terms of time commitment to stand out as I believe MEWS is a great workplace to meet fantastic people and a great opportunity to take my career to the next level.
Obviously things such as a CI/CD pipeline and other precautions and/or consideration will still be missing, and I would love to chat about those with you.
I really enjoyed the assesments and also took it as a chance to learn and put in practice something new such as the use of React-Query to fetch and handle data and Vitest as testing framework. I really wanted to show my pre-active capability and willingness in learning something new and be productive with it in no time (ish).
Finally I do thank you all for the opportunity given me so far and I hope you'll find interesting what I put together for you at this step of the interview.
Thanks,
Raf